Re #22788 Use highestVersion instead of own in AlgFactory

Framework/API/inc/MantidAPI/AlgorithmFactory.h

@@ -133,9 +133,6 @@ public:
   /// Get the algorithm categories
   const std::map<std::string, bool> getCategoriesWithState() const;
 
-  /// Returns a single algorithm descriptor
-  int getAlgLatestVersion(const std::string &algName) const;
-
   /// Returns algorithm descriptors.
   std::vector<AlgorithmDescriptor>
   getDescriptors(bool includeHidden = false) const;

Framework/API/src/AlgorithmFactory.cpp

@@ -306,26 +306,6 @@ AlgorithmFactoryImpl::getCategories(bool includeHidden) const {
   return validCategories;
 }
 
-/**
-  * Returns a the latest version number of the given algorithm
-  *
-  * @param algName The name of the algorithm to get a version for
-  * @param throwIfNotRegistered (Default true) Throw if the algorithm is not
-  *registered
-  * @return Integer of the latest algorithm version or -1 if it does not exist
-  * @throws std::runtime_error if algorithm does not exist and throw is true
-  */
-int AlgorithmFactoryImpl::getAlgLatestVersion(
-    const std::string &algName) const {
-  auto it = m_vmap.find(algName);
-
-  if (it == m_vmap.end()) {
-    throw std::runtime_error("Algorithm not registered " + algName);
-  }
-
-  return it->second;
-}
-
 /**
 * Get a list of descriptor objects used to order the algorithms in the stored
 * map

Framework/API/src/NotebookBuilder.cpp

@@ -124,7 +124,7 @@ NotebookBuilder::buildAlgorithmString(AlgorithmHistory_const_sptr algHistory) {
     //...or only specify algorithm versions when they're not the newest version
     const auto &algName = algHistory->name();
     int latestVersion =
-        AlgorithmFactory::Instance().getAlgLatestVersion(algName);
+        AlgorithmFactory::Instance().highestVersion(algName);
     // If a newer version of this algorithm exists, then this must be an old
     // version.
     if (latestVersion > algHistory->version()) {

Framework/API/src/ScriptBuilder.cpp

@@ -198,7 +198,7 @@ ScriptBuilder::buildAlgorithmString(AlgorithmHistory_const_sptr algHistory) {
     //...or only specify algorithm versions when they're not the newest version
     const auto &algName = algHistory->name();
     int latestVersion =
-        AlgorithmFactory::Instance().getAlgLatestVersion(algName);
+        AlgorithmFactory::Instance().highestVersion(algName);
     // If a newer version of this algorithm exists, then this must be an old
     // version.
     if (latestVersion > algHistory->version()) {

Framework/API/test/AlgorithmFactoryTest.h

@@ -187,25 +187,6 @@ public:
     TS_ASSERT_EQUALS(noOfAlgs - 1, descriptors.size());
   }
 
-  void testGetLatestVersion() {
-    auto &algFactory = AlgorithmFactory::Instance();
-
-    const std::string algName = "ToyAlgorithm";
-    algFactory.subscribe<ToyAlgorithm>();
-    algFactory.subscribe<ToyAlgorithmTwo>();
-
-    int version = -1;
-    TS_ASSERT_THROWS_NOTHING(version = algFactory.getAlgLatestVersion(algName));
-
-    TS_ASSERT_EQUALS(version, 2);
-
-    algFactory.unsubscribe(algName, 1);
-    algFactory.unsubscribe(algName, 2);
-
-    TS_ASSERT_THROWS(algFactory.getAlgLatestVersion(algName),
-                     std::runtime_error);
-  }
-
   void testGetCategories() {
     auto &algFactory = AlgorithmFactory::Instance();
     algFactory.subscribe<CategoryAlgorithm>();