Merge pull request #28124 from...

Merge pull request #28124 from mantidproject/28055_fix_function_crashes_when_adding_to_multi_domain_fitting

Fix crash when adding some functions to multidataset fitting

Framework/CurveFitting/src/Functions/GaussianComptonProfile.cpp

@@ -109,6 +109,9 @@ void GaussianComptonProfile::massProfile(double *result, const size_t nData,
 
   const auto &modq = modQ();
   const auto &ei = e0();
+  if (modq.empty() || ei.empty()) {
+    throw std::runtime_error("The Q values or e0 values have not been set");
+  }
   // Include e_i^0.1*mass/q pre-factor
   for (size_t j = 0; j < nData; ++j) {
     const double q = modq[j];

Framework/CurveFitting/src/Functions/GramCharlierComptonProfile.cpp

@@ -322,6 +322,10 @@ void GramCharlierComptonProfile::addFSETerm(std::vector<double> &lhs) const {
   if (m_userFixedFSE)
     kfse *= getParameter("C_0");
 
+  if (m_yfine.empty() || m_qfine.empty()) {
+    throw std::runtime_error("The Y values or Q values have not been set");
+  }
+
   for (int j = 0; j < NFINE_Y; ++j) {
     const double y = m_yfine[j] / M_SQRT2 / wg;
     const double he3 = boost::math::hermite(3, y);

Framework/CurveFitting/src/Functions/MultivariateGaussianComptonProfile.cpp

@@ -134,6 +134,9 @@ void MultivariateGaussianComptonProfile::massProfile(
 
   const auto &yspace = ySpace();
   const auto &modq = modQ();
+  if (modq.empty() || yspace.empty()) {
+    throw std::runtime_error("Y values or Q values not set");
+  }
 
   for (size_t i = 0; i < nData; i++) {
     const double y(yspace[i]);

docs/source/release/v5.0.0/mantidplot.rst

@@ -12,6 +12,8 @@ Bugfixes
 ########
 - The Show Instruments right click menu option is now disabled for workspaces that have had their spectrum axis converted to another axis using :ref:`ConvertSpectrumAxis <algm-ConvertSpectrumAxis>`.  Once this axis has been converetd the workspace loses it's link between the data values and the detectors they were recorded on so we cannot display it in the instrument view.
 - Fixed an issue with Workspace History where unrolling consecutive workflow algorithms would result in only one of the algorithms being unrolled.
+- Fixed an issue where adding specific functions to the multi-dataset fitting interface caused it to crash
 - Fixed an issue where mantid crashed if you cleared the functions in the multi-dataset fitting interface
 
+
 :ref:`Release 5.0.0 <v5.0.0>`
\ No newline at end of file

qt/scientific_interfaces/MultiDatasetFit/MDFFunctionPlotData.cpp

@@ -56,6 +56,7 @@ void MDFFunctionPlotData::setDomain(double startX, double endX, size_t nX) {
   Mantid::API::FunctionDomain1DVector x(startX, endX, nX);
   Mantid::API::FunctionValues y(x);
   try {
+    m_function.get()->setUpForFit();
     m_function->function(x, y);
   } catch (std::invalid_argument &) {
     // Do nothing.