Renamed cellChanged to cellTextChanged and added oldValue to params

- Renamed signal and assosiated notification methods.
- Added old text as a signal parameter.

Re #22263

qt/python/mantidqtpython/mantidqtpython_def.sip

@@ -1549,8 +1549,10 @@ class JobTreeViewSubscriber {
 #include "MantidQtWidgets/Common/Batch/JobTreeView.h"
 %End
 public:
-  virtual void notifyCellChanged(const MantidQt::MantidWidgets::Batch::RowLocation& itemIndex, int column,
-                                 const std::string& newValue) = 0;
+  virtual void notifyCellTextChanged(const MantidQt::MantidWidgets::Batch::RowLocation& itemIndex,
+                                     int column,
+                                     const std::string& oldValue,
+                                     const std::string& newValue) = 0;
   virtual void notifyRowInserted(const MantidQt::MantidWidgets::Batch::RowLocation& itemIndex) = 0;
   virtual void notifyRemoveRowsRequested(
     const std::vector<MantidQt::MantidWidgets::Batch::RowLocation>& locationsOfRowsToRemove) = 0;
@@ -1658,8 +1660,10 @@ class JobTreeViewSignalAdapter : public QObject, public MantidQt::MantidWidgets:
 %End
 public:
   JobTreeViewSignalAdapter(MantidQt::MantidWidgets::Batch::JobTreeView &view, QObject *parent = nullptr);
-  virtual void notifyCellChanged(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex, int column,
-                                 const std::string &newValue);
+  virtual void notifyCellTextChanged(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex,
+                                     int column,
+                                     const std::string &oldValue,
+                                     const std::string &newValue);
   virtual void notifyRowInserted(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex);
   virtual void notifyRemoveRowsRequested(
       const std::vector<MantidQt::MantidWidgets::Batch::RowLocation> &locationsOfRowsToRemove);
@@ -1667,8 +1671,10 @@ public:
   virtual void notifyPasteRowsRequested();
   virtual void notifyFilterReset();
 signals:
-  void cellChanged(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex, int column,
-                   std::string newValue);
+  void cellTextChanged(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex,
+                       int column,
+                       std::string oldValue,
+                       std::string newValue);
   void rowInserted(const MantidQt::MantidWidgets::Batch::RowLocation &itemIndex);
   void filterReset();
   void removeRowsRequested(

qt/widgets/common/inc/MantidQtWidgets/Common/Batch/JobTreeView.h

@@ -18,8 +18,9 @@ namespace Batch {
 
 class EXPORT_OPT_MANTIDQT_COMMON JobTreeViewSubscriber {
 public:
-  virtual void notifyCellChanged(RowLocation const &itemIndex, int column,
-                                 std::string const &newValue) = 0;
+  virtual void notifyCellTextChanged(RowLocation const &itemIndex, int column,
+                                     std::string const &oldValue,
+                                     std::string const &newValue) = 0;
   virtual void notifyRowInserted(RowLocation const &newRowLocation) = 0;
   virtual void notifyRemoveRowsRequested(
       std::vector<RowLocation> const &locationsOfRowsToRemove) = 0;
@@ -32,12 +33,10 @@ public:
 class EXPORT_OPT_MANTIDQT_COMMON JobTreeView : public QTreeView {
   Q_OBJECT
 public:
-  // JobTreeView(QWidget *parent = nullptr);
   JobTreeView(QStringList const &columnHeadings, Cell const &defaultCellStyle,
               QWidget *parent = nullptr);
 
   void enableFiltering();
-
   void filterRowsBy(std::unique_ptr<RowPredicate> predicate);
   void filterRowsBy(RowPredicate *predicate);
   void resetFilter();
@@ -84,7 +83,7 @@ public:
   boost::optional<std::vector<Subtree>> selectedSubtrees() const;
   boost::optional<std::vector<RowLocation>> selectedSubtreeRoots() const;
 
-  bool hasNoSelectedChildren(QModelIndex const &index) const;
+  bool hasNoSelectedDescendants(QModelIndex const &index) const;
   void appendAllDescendants(QModelIndexList &selectedRows,
                             QModelIndex const &index) const;
   QModelIndexList

qt/widgets/common/inc/MantidQtWidgets/Common/Batch/JobTreeViewSignalAdapter.h

@@ -12,8 +12,9 @@ class EXPORT_OPT_MANTIDQT_COMMON JobTreeViewSignalAdapter
 public:
   JobTreeViewSignalAdapter(JobTreeView &view, QObject *parent = nullptr);
 
-  void notifyCellChanged(RowLocation const &itemIndex, int column,
-                         std::string const &newValue) override;
+  void notifyCellTextChanged(RowLocation const &itemIndex, int column,
+                             std::string const &oldValue,
+                             std::string const &newValue) override;
   void notifyRowInserted(RowLocation const &newRowLocation) override;
   void notifyRemoveRowsRequested(
       std::vector<RowLocation> const &locationsOfRowsToRemove) override;
@@ -21,8 +22,10 @@ public:
   void notifyPasteRowsRequested() override;
   void notifyFilterReset() override;
 signals:
-  void cellChanged(MantidQt::MantidWidgets::Batch::RowLocation const &itemIndex,
-                   int column, std::string newValue);
+  void
+  cellTextChanged(MantidQt::MantidWidgets::Batch::RowLocation const &itemIndex,
+                  int column, std::string const &oldValue,
+                  std::string const &newValue);
   void rowInserted(
       MantidQt::MantidWidgets::Batch::RowLocation const &newRowLocation);
   void filterReset();

qt/widgets/common/src/Batch/JobTreeView.cpp

@@ -29,12 +29,18 @@ JobTreeView::JobTreeView(QStringList const &columnHeadings,
 }
 
 void JobTreeView::commitData(QWidget *editor) {
+  auto cellTextBefore =
+      m_adaptedMainModel.cellFromCellIndex(m_lastEdited).contentText();
   QTreeView::commitData(editor);
-  auto cellProperties = m_adaptedMainModel.cellFromCellIndex(m_lastEdited);
-  auto cellText = cellProperties.contentText();
-  m_notifyee->notifyCellChanged(rowLocation().atIndex(m_lastEdited),
-                                m_lastEdited.column(), cellText);
-  m_hasEditorOpen = false;
+  auto cellText =
+      m_adaptedMainModel.cellFromCellIndex(m_lastEdited).contentText();
+  if (cellText != cellTextBefore) {
+    resizeColumnToContents(m_lastEdited.column());
+    m_hasEditorOpen = false;
+    m_notifyee->notifyCellTextChanged(rowLocation().atIndex(m_lastEdited),
+                                      m_lastEdited.column(), cellTextBefore,
+                                      cellText);
+  }
 }
 
 void JobTreeView::filterRowsBy(std::unique_ptr<RowPredicate> predicate) {

qt/widgets/common/src/Batch/JobTreeViewSignalAdapter.cpp

@@ -12,10 +12,10 @@ JobTreeViewSignalAdapter::JobTreeViewSignalAdapter(JobTreeView &view,
   view.subscribe(*this);
 }
 
-void JobTreeViewSignalAdapter::notifyCellChanged(RowLocation const &itemIndex,
-                                                 int column,
-                                                 std::string const &newValue) {
-  emit cellChanged(itemIndex, column, newValue);
+void JobTreeViewSignalAdapter::notifyCellTextChanged(
+    RowLocation const &itemIndex, int column, std::string const &oldValue,
+    std::string const &newValue) {
+  emit cellTextChanged(itemIndex, column, oldValue, newValue);
 }
 
 void JobTreeViewSignalAdapter::notifyRowInserted(

scripts/Interface/ui/batchwidget/batch_widget_gui.py

@@ -52,7 +52,7 @@ class DataProcessorGui(QtGui.QMainWindow, Ui_BatchWidgetWindow):
     def on_remove_runs_request(self, runs_to_remove):
         self.table.removeRows(runs_to_remove)
 
-    def on_cell_updated(self, row, col, cell_content):
+    def on_cell_updated(self, row, col, old_content, cell_content):
         cell = self.table.cellAt(row, col)
         if cell_content == 'Invalid':
             cell.setIconFilePath(':/invalid.png')
@@ -63,7 +63,7 @@ class DataProcessorGui(QtGui.QMainWindow, Ui_BatchWidgetWindow):
             cell.setBorderColor('darkGrey')
             self.table.setCellAt(row, col, cell)
 
-        print("Updated row {} col {} with text {}".format(row.path(), col, cell_content))
+        print("Updated text at row {} col {} from {} to {}.".format(row.path(), col, old_content, cell_content))
 
     def on_row_inserted(self, rowLoc):
         print("Row inserted at {}".format(rowLoc.path()))
@@ -110,7 +110,7 @@ class DataProcessorGui(QtGui.QMainWindow, Ui_BatchWidgetWindow):
         self.table_signals.removeRowsRequested.connect(self.on_remove_runs_request)
         self.table_signals.copyRowsRequested.connect(self.on_copy_runs_request)
         self.table_signals.pasteRowsRequested.connect(self.on_paste_rows_request)
-        self.table_signals.cellChanged.connect(self.on_cell_updated)
+        self.table_signals.cellTextChanged.connect(self.on_cell_updated)
         self.table_signals.rowInserted.connect(self.on_row_inserted)
         self.table_signals.filterReset.connect(self.on_filter_reset)