Fix warnings with GCC 7

Framework/HistogramData/test/HistogramIteratorTest.h

@@ -301,9 +301,10 @@ public:
 
   void test_convert_counts_to_frequency_for_each_item_sparse() {
     double total = 0;
+    double floor = static_cast<double>(histSize) - 5.0;
     for (size_t i = 0; i < nHists; i++) {
       for (auto &item : m_hist) {
-        if (item.counts() > histSize - 5)
+        if (item.counts() > floor)
           total += item.frequency();
       }
     }
@@ -311,11 +312,12 @@ public:
 
   void test_convert_counts_to_frequency_once_per_histogram_sparse() {
     double total = 0;
+    double floor = static_cast<double>(histSize) - 5.0;
     for (size_t i = 0; i < nHists; i++) {
       const auto &counts = m_hist.counts();
       const auto &frequencies = m_hist.frequencies();
       for (size_t j = 0; j < histSize; ++j)
-        if (counts[j] > histSize - 5)
+        if (counts[j] > floor)
           total += frequencies[j];
     }
   }

buildconfig/CMake/GoogleTest.in

@@ -16,6 +16,7 @@ ExternalProject_Add(googletest
             COMMAND "@GIT_EXECUTABLE@" apply --whitespace fix "@CMAKE_SOURCE_DIR@/buildconfig/CMake/googletest_override.patch"
             COMMAND "@GIT_EXECUTABLE@" apply --whitespace fix "@CMAKE_SOURCE_DIR@/buildconfig/CMake/googletest_static.patch"
             COMMAND "@GIT_EXECUTABLE@" apply --whitespace fix "@CMAKE_SOURCE_DIR@/buildconfig/CMake/googletest_msvc_cpp11.patch"
+            COMMAND "@GIT_EXECUTABLE@" apply --whitespace fix "@CMAKE_SOURCE_DIR@/buildconfig/CMake/googletest_wconversion.patch"
   CONFIGURE_COMMAND ""
   BUILD_COMMAND     ""
   INSTALL_COMMAND   ""

buildconfig/CMake/googletest_wconversion.patch

+diff --git a/googlemock/include/gmock/gmock-matchers.h b/googlemock/include/gmock/gmock-matchers.h
+index 33b37a7..fbb5734 100644
+--- a/googlemock/include/gmock/gmock-matchers.h
++++ b/googlemock/include/gmock/gmock-matchers.h
+@@ -1620,8 +1620,13 @@ class VariadicMatcher {
+   }
+ 
+  private:
++#if defined(__GNUC__) && !defined(__clang__)
++#pragma GCC diagnostic ignored "-Wconversion"
++#endif
+   typedef MatcherList<sizeof...(Args), Args...> MatcherListType;
+-
++#if defined(__GNUC__) && !defined(__clang__)
++#pragma GCC diagnostic warning "-Wconversion"
++#endif
+   const typename MatcherListType::ListType matchers_;
+ 
+   GTEST_DISALLOW_ASSIGN_(VariadicMatcher);

qt/scientific_interfaces/ISISReflectometry/ReflDataProcessorPresenter.cpp

@@ -697,7 +697,8 @@ bool ReflDataProcessorPresenter::parseUniform(TimeSlicingInfo &slicing,
   if (mws != nullptr) {
     const auto run = mws->run();
     const auto totalDuration = run.endTime() - run.startTime();
-    double totalDurationSec = totalDuration.total_seconds();
+    double totalDurationSec =
+        static_cast<double>(totalDuration.total_seconds());
     double sliceDuration = .0;
     size_t numSlices = 0;