refs #13989. Push issues upwards.

We need to be able to push issues back up to the caller.

MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ReflLegacyTransferStrategy.h

@@ -35,7 +35,7 @@ namespace MantidQt
     {
     public:
       virtual std::vector<std::map<std::string, std::string>>
-      transferRuns(const SearchResultMap &searchResults,
+      transferRuns(SearchResultMap &searchResults,
                    Mantid::Kernel::ProgressBase &progress);
 
       virtual ReflLegacyTransferStrategy *clone() const;

MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ReflMeasureTransferStrategy.h

@@ -57,7 +57,7 @@ public:
   ReflMeasureTransferStrategy(const ReflMeasureTransferStrategy &other);
 
   virtual std::vector<std::map<std::string, std::string>>
-  transferRuns(const SearchResultMap &searchResults,
+  transferRuns(SearchResultMap &searchResults,
                Mantid::Kernel::ProgressBase &progress);
 
   virtual ReflMeasureTransferStrategy *clone() const;

MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/ReflTransferStrategy.h

@@ -25,6 +25,7 @@ namespace MantidQt
         : description(desc), location(loc) {}
     std::string description;
     std::string location;
+    std::string issues;
   };
 
   /// Helper typdef for map of SearchResults keyed by run
@@ -67,7 +68,7 @@ namespace MantidQt
        * for those columns
        */
       virtual std::vector<std::map<std::string, std::string>>
-      transferRuns(const SearchResultMap &searchResults,
+      transferRuns(SearchResultMap &searchResults,
                    Mantid::Kernel::ProgressBase &progress) = 0;
 
       /**

MantidQt/CustomInterfaces/src/ReflLegacyTransferStrategy.cpp

@@ -10,8 +10,7 @@ namespace MantidQt
   namespace CustomInterfaces
   {
   std::vector<std::map<std::string, std::string>>
-  ReflLegacyTransferStrategy::transferRuns(
-      const SearchResultMap &searchResults,
+  ReflLegacyTransferStrategy::transferRuns(SearchResultMap &searchResults,
       Mantid::Kernel::ProgressBase &progress) {
       /*
        * If the descriptions are the same except for theta: same group, different rows.

MantidQt/CustomInterfaces/src/ReflMeasureTransferStrategy.cpp

@@ -40,7 +40,7 @@ ReflMeasureTransferStrategy::~ReflMeasureTransferStrategy() {}
 
 std::vector<std::map<std::string, std::string>>
 MantidQt::CustomInterfaces::ReflMeasureTransferStrategy::transferRuns(
-    const SearchResultMap &searchResults,
+    SearchResultMap &searchResults,
     Mantid::Kernel::ProgressBase &progress) {
 
   typedef std::vector<Measurement> VecSameMeasurement;
@@ -69,6 +69,9 @@ MantidQt::CustomInterfaces::ReflMeasureTransferStrategy::transferRuns(
         mapOfMeasurements[metaData.id()].push_back(metaData);
       }
     }
+    else{
+        it->second.issues = metaData.whyUnuseable();
+    }
 
     // Obtaining metadata could take time.
     progress.report();

MantidQt/CustomInterfaces/test/ReflMeasureTransferStrategyTest.h

@@ -214,7 +214,7 @@ public:
 
     MockProgressBase progress;
     // Nothing obtained. No progress to report.
-    EXPECT_CALL(progress, doReport(_)).Times(Exactly(0));
+    EXPECT_CALL(progress, doReport(_)).Times(Exactly(1));
 
     ReflMeasureTransferStrategy strategy(
         std::move(std::unique_ptr<MockICatalogInfo>(mockCatInfo)),