Fixed presenter leaving scope and call argument errors Re #23035

scripts/ErrorReporter/error_dialog_app.py

@@ -30,7 +30,7 @@ def main():
         return int(command_line_args.exit_code)
     app = QtGui.QApplication(sys.argv)
     form = CrashReportPage(show_continue_terminate=False)
-    ErrorReporterPresenter(form, command_line_args.exit_code)
+    presenter = ErrorReporterPresenter(form, command_line_args.exit_code)
     app.exec_()
     return int(command_line_args.exit_code)
 

scripts/ErrorReporter/error_report_presenter.py

@@ -2,24 +2,24 @@ from mantid.kernel import ErrorReporter, UsageService
 from mantid.kernel import Logger
 
 
-class ErrorReporterPresenter():
+class ErrorReporterPresenter(object):
     def __init__(self, view, exit_code):
+        self.error_log = Logger("error")
         self._view = view
         self._exit_code = exit_code
-        self._view.connect_signal(self.error_handler)
+        self._view.action.connect(self.error_handler)
+        print('Connected')
         self._view.show()
-        self.error_log = Logger("error")
 
     def error_handler(self, continue_working, share, name, email):
+        print("Recieving signal")
         if share == 0:
             errorReporter = ErrorReporter(
-                "mantidplot",UsageService.getUpTime(), UsageService.isEnabled(), self._exit_code,
-                True, str(name), str(email))
+                "mantidplot", UsageService.getUpTime(), self._exit_code, True, str(name), str(email))
             errorReporter.sendErrorReport()
         elif share == 1:
             errorReporter = ErrorReporter(
-                "mantidplot",UsageService.getUpTime(), UsageService.isEnabled(), self._exit_code,
-                False, str(name), str(email))
+                "mantidplot", UsageService.getUpTime(), self._exit_code, False, str(name), str(email))
             errorReporter.sendErrorReport()
 
         if not continue_working:

scripts/ErrorReporter/errorreport.py

@@ -39,9 +39,6 @@ class CrashReportPage(QtGui.QWidget, ui_errorreport.Ui_Errorreport):
     def quit (self):
         self.quit_signal.emit()
 
-    def connect_signal(self, slot):
-        self.action.connect(slot)
-
     def fullShare(self):
         self.action.emit(self.continue_working, 0, self.input_name, self.input_email)
         self.close()