Re #28460 fix get_window_title so it returns correct value + add test

qt/applications/workbench/workbench/plotting/figuremanager.py

@@ -368,7 +368,7 @@ class FigureManagerWorkbench(FigureManagerBase, QObject):
         self.toolbar.hold()
 
     def get_window_title(self):
-        return isinstance(self.window.windowTitle(), str)
+        return self.window.windowTitle()
 
     def set_window_title(self, title):
         self.window.setWindowTitle(title)

qt/applications/workbench/workbench/plotting/test/test_figuremanager.py

@@ -23,6 +23,14 @@ class FigureManagerWorkbenchTest(unittest.TestCase):
         fig_mgr = FigureManagerWorkbench(canvas, 1)
         self.assertNotEqual(fig_mgr, None)
 
+    @patch("workbench.plotting.figuremanager.QAppThreadCall")
+    def test_window_title(self, mock_qappthread):
+        mock_qappthread.return_value = mock_qappthread
+        fig = MagicMock()
+        canvas = FigureCanvasQTAgg(fig)
+        fig_mgr = FigureManagerWorkbench(canvas, 1)
+        self.assertEqual(fig_mgr.get_window_title(), "Figure 1")
+
 
 if __name__ == "__main__":
     unittest.main()