Skip to content
Snippets Groups Projects
Commit 851ba6e8 authored by Owen Arnold's avatar Owen Arnold
Browse files

Revert "refs #11304. u, v to U, V"

Reverting because U implies the U matrix. We'll keep things lower case and
fix the test instead.

This reverts commit ed491ad6.
parent ed491ad6
No related branches found
No related tags found
No related merge requests found
...@@ -114,9 +114,9 @@ class CreateMD(DataProcessorAlgorithm): ...@@ -114,9 +114,9 @@ class CreateMD(DataProcessorAlgorithm):
self.declareProperty(FloatArrayProperty('Angdeg', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice angles' ) self.declareProperty(FloatArrayProperty('Angdeg', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice angles' )
self.declareProperty(FloatArrayProperty('U', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice vector parallel to neutron beam' ) self.declareProperty(FloatArrayProperty('u', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice vector parallel to neutron beam' )
self.declareProperty(FloatArrayProperty('V', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice vector perpendicular to neutron beam in the horizontal plane' ) self.declareProperty(FloatArrayProperty('v', values=[], validator=FloatArrayMandatoryValidator(), direction=Direction.Input ), doc='Lattice vector perpendicular to neutron beam in the horizontal plane' )
self.declareProperty(FloatArrayProperty('Psi', values=[], direction=Direction.Input), doc='Psi rotation in degrees. Optional or one entry per run.' ) self.declareProperty(FloatArrayProperty('Psi', values=[], direction=Direction.Input), doc='Psi rotation in degrees. Optional or one entry per run.' )
...@@ -131,8 +131,8 @@ class CreateMD(DataProcessorAlgorithm): ...@@ -131,8 +131,8 @@ class CreateMD(DataProcessorAlgorithm):
emode = self.getProperty('Emode').value emode = self.getProperty('Emode').value
alatt = self.getProperty('Alatt').value alatt = self.getProperty('Alatt').value
angdeg = self.getProperty('Angdeg').value angdeg = self.getProperty('Angdeg').value
u = self.getProperty('U').value u = self.getProperty('u').value
v = self.getProperty('V').value v = self.getProperty('v').value
psi = self.getProperty('Psi').value psi = self.getProperty('Psi').value
gl = self.getProperty('Gl').value gl = self.getProperty('Gl').value
gs = self.getProperty('Gs').value gs = self.getProperty('Gs').value
...@@ -176,8 +176,8 @@ class CreateMD(DataProcessorAlgorithm): ...@@ -176,8 +176,8 @@ class CreateMD(DataProcessorAlgorithm):
emode = self.getProperty('Emode').value emode = self.getProperty('Emode').value
alatt = self.getProperty('Alatt').value alatt = self.getProperty('Alatt').value
angdeg = self.getProperty('Angdeg').value angdeg = self.getProperty('Angdeg').value
u = self.getProperty('U').value u = self.getProperty('u').value
v = self.getProperty('V').value v = self.getProperty('v').value
psi = self.getProperty('Psi').value psi = self.getProperty('Psi').value
gl = self.getProperty('Gl').value gl = self.getProperty('Gl').value
gs = self.getProperty('Gs').value gs = self.getProperty('Gs').value
......
...@@ -27,8 +27,8 @@ class CreateMDTest(unittest.TestCase): ...@@ -27,8 +27,8 @@ class CreateMDTest(unittest.TestCase):
alg.setProperty("Emode", "Direct") alg.setProperty("Emode", "Direct")
alg.setProperty("Alatt", [1,1,1]) alg.setProperty("Alatt", [1,1,1])
alg.setProperty("Angdeg", [90,90,90]) alg.setProperty("Angdeg", [90,90,90])
alg.setProperty("U", [0,0,1]) alg.setProperty("u", [0,0,1])
alg.setProperty("V", [1,0,0]) alg.setProperty("v", [1,0,0])
def test_psi_right_size(self): def test_psi_right_size(self):
...@@ -43,8 +43,8 @@ class CreateMDTest(unittest.TestCase): ...@@ -43,8 +43,8 @@ class CreateMDTest(unittest.TestCase):
alg.setProperty("Emode", "Direct") alg.setProperty("Emode", "Direct")
alg.setProperty("Alatt", [1,1,1]) alg.setProperty("Alatt", [1,1,1])
alg.setProperty("Angdeg", [90,90,90]) alg.setProperty("Angdeg", [90,90,90])
alg.setProperty("U", [0,0,1]) alg.setProperty("u", [0,0,1])
alg.setProperty("V", [1,0,0]) alg.setProperty("v", [1,0,0])
alg.setProperty("Psi", [0, 0, 0]) # Too large alg.setProperty("Psi", [0, 0, 0]) # Too large
alg.setProperty("Gl", [0]) # Right size alg.setProperty("Gl", [0]) # Right size
alg.setProperty("Gs", [0]) # Right size alg.setProperty("Gs", [0]) # Right size
...@@ -64,8 +64,8 @@ class CreateMDTest(unittest.TestCase): ...@@ -64,8 +64,8 @@ class CreateMDTest(unittest.TestCase):
alg.setProperty("Emode", "Direct") alg.setProperty("Emode", "Direct")
alg.setProperty("Alatt", [1,1,1]) alg.setProperty("Alatt", [1,1,1])
alg.setProperty("Angdeg", [90,90,90]) alg.setProperty("Angdeg", [90,90,90])
alg.setProperty("U", [0,0,1]) alg.setProperty("u", [0,0,1])
alg.setProperty("V", [1,0,0]) alg.setProperty("v", [1,0,0])
alg.setProperty("Psi", [0]) # Right size alg.setProperty("Psi", [0]) # Right size
alg.setProperty("Gl", [0, 0]) # Too many alg.setProperty("Gl", [0, 0]) # Too many
alg.setProperty("Gs", [0]) # Right size alg.setProperty("Gs", [0]) # Right size
...@@ -85,8 +85,8 @@ class CreateMDTest(unittest.TestCase): ...@@ -85,8 +85,8 @@ class CreateMDTest(unittest.TestCase):
alg.setProperty("Emode", "Direct") alg.setProperty("Emode", "Direct")
alg.setProperty("Alatt", [1,1,1]) alg.setProperty("Alatt", [1,1,1])
alg.setProperty("Angdeg", [90,90,90]) alg.setProperty("Angdeg", [90,90,90])
alg.setProperty("U", [0,0,1]) alg.setProperty("u", [0,0,1])
alg.setProperty("V", [1,0,0]) alg.setProperty("v", [1,0,0])
alg.setProperty("Psi", [0]) # Right size alg.setProperty("Psi", [0]) # Right size
alg.setProperty("Gl", [0]) # Right size alg.setProperty("Gl", [0]) # Right size
alg.setProperty("Gs", [0,0]) # Too large alg.setProperty("Gs", [0,0]) # Too large
...@@ -106,8 +106,8 @@ class CreateMDTest(unittest.TestCase): ...@@ -106,8 +106,8 @@ class CreateMDTest(unittest.TestCase):
alg.setProperty("InputWorkspaces", ['input_workspace']) alg.setProperty("InputWorkspaces", ['input_workspace'])
alg.setProperty("Alatt", [1,1,1]) alg.setProperty("Alatt", [1,1,1])
alg.setProperty("Angdeg", [90,90,90]) alg.setProperty("Angdeg", [90,90,90])
alg.setProperty("U", [0,0,1]) alg.setProperty("u", [0,0,1])
alg.setProperty("V", [1,0,0]) alg.setProperty("v", [1,0,0])
alg.execute() alg.execute()
out_ws = AnalysisDataService.retrieve("mdworkspace") out_ws = AnalysisDataService.retrieve("mdworkspace")
......
...@@ -47,7 +47,7 @@ CreateMD steps use :ref:`algm-ConvertToMDMinMaxGlobal` to determine the min and ...@@ -47,7 +47,7 @@ CreateMD steps use :ref:`algm-ConvertToMDMinMaxGlobal` to determine the min and
AddSampleLog(Workspace=current_ws,LogName='Ei',LogText='3.0',LogType='Number') AddSampleLog(Workspace=current_ws,LogName='Ei',LogText='3.0',LogType='Number')
# Execute CreateMD # Execute CreateMD
new_mdew = CreateMD(current_ws, Emode='Direct', Alatt=[1.4165, 1.4165,1.4165], Angdeg=[ 90, 90, 90], U=[1, 0, 0,], V=[0,1,0], Psi=6, Gs=0, Gl=[0]) new_mdew = CreateMD(current_ws, Emode='Direct', Alatt=[1.4165, 1.4165,1.4165], Angdeg=[ 90, 90, 90], u=[1, 0, 0,], v=[0,1,0], Psi=6, Gs=0, Gl=[0])
# Show dimensionality and dimension names # Show dimensionality and dimension names
ndims = new_mdew.getNumDims() ndims = new_mdew.getNumDims()
...@@ -84,7 +84,7 @@ Output ...@@ -84,7 +84,7 @@ Output
gs.append(0.0) gs.append(0.0)
# Convert and merge # Convert and merge
new_merged = CreateMD(input_runs, Emode='Direct', Alatt=[1.4165, 1.4165,1.4165], Angdeg=[ 90, 90, 90], U=[1, 0, 0,], V=[0,1,0], Psi=psi, Gl=gl, Gs=gs) new_merged = CreateMD(input_runs, Emode='Direct', Alatt=[1.4165, 1.4165,1.4165], Angdeg=[ 90, 90, 90], u=[1, 0, 0,], v=[0,1,0], Psi=psi, Gl=gl, Gs=gs)
# Show dimensionality and dimension names # Show dimensionality and dimension names
ndims = new_merged.getNumDims() ndims = new_merged.getNumDims()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment