Refs #30686. Use template for updating domain functions.

qt/widgets/common/inc/MantidQtWidgets/Common/FitScriptGenerator.ui

@@ -148,13 +148,13 @@
            <widget class="QPushButton" name="pbSelectedDomains">
             <property name="minimumSize">
              <size>
-              <width>98</width>
+              <width>100</width>
               <height>0</height>
              </size>
             </property>
             <property name="maximumSize">
              <size>
-              <width>98</width>
+              <width>100</width>
               <height>16777215</height>
              </size>
             </property>
@@ -170,13 +170,13 @@
            <widget class="QPushButton" name="pbAllDomains">
             <property name="minimumSize">
              <size>
-              <width>98</width>
+              <width>100</width>
               <height>0</height>
              </size>
             </property>
             <property name="maximumSize">
              <size>
-              <width>98</width>
+              <width>100</width>
               <height>16777215</height>
              </size>
             </property>

qt/widgets/common/inc/MantidQtWidgets/Common/FitScriptGeneratorDataTable.h

@@ -58,6 +58,8 @@ public:
   [[nodiscard]] std::vector<FitDomainIndex> allRows() const;
   [[nodiscard]] std::vector<FitDomainIndex> selectedRows() const;
 
+  bool hasLoadedData() const;
+
   [[nodiscard]] QString selectedDomainFunctionPrefix() const;
 
   void removeDomain(std::string const &workspaceName,

qt/widgets/common/inc/MantidQtWidgets/Common/FitScriptGeneratorPresenter.h

@@ -86,14 +86,6 @@ private:
   void updateEndX(std::string const &workspaceName,
                   WorkspaceIndex workspaceIndex, double endX);
 
-  void
-  removeFunctionForDomains(std::string const &function,
-                           std::vector<FitDomainIndex> const &domainIndices);
-  void addFunctionForDomains(std::string const &function,
-                             std::vector<FitDomainIndex> const &domainIndices);
-  void setFunctionForDomains(std::string const &function,
-                             std::vector<FitDomainIndex> const &domainIndices);
-
   void updateParameterTie(std::string const &workspaceName,
                           WorkspaceIndex workspaceIndex,
                           std::string const &parameter, std::string const &tie);
@@ -102,6 +94,11 @@ private:
 
   void checkForWarningMessages();
 
+  template <void (IFitScriptGeneratorModel::*func)(
+      std::string const &workspaceName, WorkspaceIndex workspaceIndex,
+      std::string const &function)>
+  void updateDomainFunctions(std::string const &function);
+
   std::vector<std::string> m_warnings;
 
   IFitScriptGeneratorView *m_view;

qt/widgets/common/inc/MantidQtWidgets/Common/FitScriptGeneratorView.h

@@ -57,6 +57,8 @@ public:
   [[nodiscard]] std::vector<FitDomainIndex> allRows() const override;
   [[nodiscard]] std::vector<FitDomainIndex> selectedRows() const override;
 
+  [[nodiscard]] bool hasLoadedData() const override;
+
   [[nodiscard]] double
   parameterValue(std::string const &parameter) const override;
   [[nodiscard]] Mantid::API::IFunction::Attribute

qt/widgets/common/inc/MantidQtWidgets/Common/IFitScriptGeneratorView.h

@@ -69,6 +69,8 @@ public:
   [[nodiscard]] virtual std::vector<FitDomainIndex> allRows() const = 0;
   [[nodiscard]] virtual std::vector<FitDomainIndex> selectedRows() const = 0;
 
+  [[nodiscard]] virtual bool hasLoadedData() const = 0;
+
   [[nodiscard]] virtual double
   parameterValue(std::string const &parameter) const = 0;
   [[nodiscard]] virtual Mantid::API::IFunction::Attribute

qt/widgets/common/src/FitScriptGeneratorDataTable.cpp

@@ -229,6 +229,10 @@ std::vector<FitDomainIndex> FitScriptGeneratorDataTable::selectedRows() const {
   return rowIndices;
 }
 
+bool FitScriptGeneratorDataTable::hasLoadedData() const {
+  return this->rowCount() > 0;
+}
+
 QString FitScriptGeneratorDataTable::selectedDomainFunctionPrefix() const {
   auto const rows = selectedRows();
   if (rows.empty())

qt/widgets/common/src/FitScriptGeneratorPresenter.cpp

@@ -175,37 +175,30 @@ void FitScriptGeneratorPresenter::handleSelectionChanged() {
 
 void FitScriptGeneratorPresenter::handleFunctionRemoved(
     std::string const &function) {
-  auto const rowIndices = getRowIndices();
-
-  if (!rowIndices.empty()) {
-    removeFunctionForDomains(function, rowIndices);
+  if (m_view->hasLoadedData()) {
+    updateDomainFunctions<&IFitScriptGeneratorModel::removeFunction>(function);
     handleSelectionChanged();
   }
 }
 
 void FitScriptGeneratorPresenter::handleFunctionAdded(
     std::string const &function) {
-  auto const rowIndices = getRowIndices();
-
-  if (rowIndices.empty()) {
+  if (m_view->hasLoadedData()) {
+    try {
+      updateDomainFunctions<&IFitScriptGeneratorModel::addFunction>(function);
+    } catch (std::invalid_argument const &ex) {
+      m_view->displayWarning(ex.what());
+    }
+  } else {
     m_view->displayWarning("Data needs to be loaded before adding a function.");
     m_view->clearFunction();
-    return;
-  }
-
-  try {
-    addFunctionForDomains(function, rowIndices);
-  } catch (std::invalid_argument const &ex) {
-    m_view->displayWarning(ex.what());
   }
 }
 
 void FitScriptGeneratorPresenter::handleFunctionReplaced(
     std::string const &function) {
-  auto const rowIndices = getRowIndices();
-
-  if (!rowIndices.empty()) {
-    setFunctionForDomains(function, rowIndices);
+  if (m_view->hasLoadedData()) {
+    updateDomainFunctions<&IFitScriptGeneratorModel::setFunction>(function);
   } else {
     m_view->displayWarning("Data needs to be loaded before adding a function.");
     m_view->clearFunction();
@@ -375,33 +368,15 @@ void FitScriptGeneratorPresenter::updateEndX(std::string const &workspaceName,
   }
 }
 
-void FitScriptGeneratorPresenter::removeFunctionForDomains(
-    std::string const &function,
-    std::vector<FitDomainIndex> const &domainIndices) {
-  for (auto const &domainIndex : domainIndices) {
-    auto const workspaceName = m_view->workspaceName(domainIndex);
-    auto const workspaceIndex = m_view->workspaceIndex(domainIndex);
-    m_model->removeFunction(workspaceName, workspaceIndex, function);
-  }
-}
-
-void FitScriptGeneratorPresenter::addFunctionForDomains(
-    std::string const &function,
-    std::vector<FitDomainIndex> const &domainIndices) {
-  for (auto const &domainIndex : domainIndices) {
-    auto const workspaceName = m_view->workspaceName(domainIndex);
-    auto const workspaceIndex = m_view->workspaceIndex(domainIndex);
-    m_model->addFunction(workspaceName, workspaceIndex, function);
-  }
-}
-
-void FitScriptGeneratorPresenter::setFunctionForDomains(
-    std::string const &function,
-    std::vector<FitDomainIndex> const &domainIndices) {
-  for (auto const &domainIndex : domainIndices) {
+template <void (IFitScriptGeneratorModel::*func)(
+    std::string const &workspaceName, WorkspaceIndex workspaceIndex,
+    std::string const &function)>
+void FitScriptGeneratorPresenter::updateDomainFunctions(
+    std::string const &function) {
+  for (auto const &domainIndex : getRowIndices()) {
     auto const workspaceName = m_view->workspaceName(domainIndex);
     auto const workspaceIndex = m_view->workspaceIndex(domainIndex);
-    m_model->setFunction(workspaceName, workspaceIndex, function);
+    (m_model->*func)(workspaceName, workspaceIndex, function);
   }
 }
 

qt/widgets/common/src/FitScriptGeneratorView.cpp

@@ -293,6 +293,10 @@ std::vector<FitDomainIndex> FitScriptGeneratorView::selectedRows() const {
   return m_dataTable->selectedRows();
 }
 
+bool FitScriptGeneratorView::hasLoadedData() const {
+  return m_dataTable->hasLoadedData();
+}
+
 double
 FitScriptGeneratorView::parameterValue(std::string const &parameter) const {
   return m_functionTreeView->getParameter(QString::fromStdString(parameter));