Re #22265 Change m_presenter to shared_ptr

This prevents a double free when closing the GUI

qt/scientific_interfaces/EnggDiffraction/EnggDiffFittingViewQtWidget.cpp

@@ -13,6 +13,7 @@
 #include <sstream>
 
 #include <boost/algorithm/string.hpp>
+#include <boost/make_shared.hpp>
 
 #include <Poco/Path.h>
 
@@ -52,13 +53,11 @@ EnggDiffFittingViewQtWidget::EnggDiffFittingViewQtWidget(
     boost::shared_ptr<IEnggDiffractionPythonRunner> mainPythonRunner)
     : IEnggDiffFittingView(), m_fittedDataVector(), m_mainMsgProvider(mainMsg),
       m_mainSettings(mainSettings), m_mainPythonRunner(mainPythonRunner),
-      m_presenter(nullptr) {
+      m_presenter(boost::make_shared<EnggDiffFittingPresenter>(
+          this, Mantid::Kernel::make_unique<EnggDiffFittingModel>(), mainCalib,
+          mainParam)) {
 
   initLayout();
-
-  m_presenter.reset(new EnggDiffFittingPresenter(
-      this, Mantid::Kernel::make_unique<EnggDiffFittingModel>(), mainCalib,
-      mainParam));
   m_presenter->notify(IEnggDiffFittingPresenter::Start);
 }
 

qt/scientific_interfaces/EnggDiffraction/EnggDiffFittingViewQtWidget.h

@@ -8,8 +8,6 @@
 
 #include "ui_EnggDiffractionQtTabFitting.h"
 
-#include <boost/scoped_ptr.hpp>
-
 // Qt classes forward declarations
 class QMessageBox;
 class QMutex;
@@ -244,7 +242,7 @@ private:
   boost::shared_ptr<IEnggDiffractionPythonRunner> m_mainPythonRunner;
 
   /// presenter as in the model-view-presenter
-  boost::scoped_ptr<IEnggDiffFittingPresenter> m_presenter;
+  boost::shared_ptr<IEnggDiffFittingPresenter> m_presenter;
 
   /// current selected instrument
   /// updated from the EnggDiffractionPresenter processInstChange