Merge pull request #22136 from mantidproject/modernize-use-using-qt

Applied clang-tidy modernize-use-using fixes for qt.

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/Common.h

@@ -14,16 +14,16 @@ class IMDDimension;
 
 namespace VATES {
 /// Vector of IMDDimension shared pointers.
-typedef std::vector<boost::shared_ptr<Mantid::Geometry::IMDDimension>>
-    DimensionVec;
+using DimensionVec =
+    std::vector<boost::shared_ptr<Mantid::Geometry::IMDDimension>>;
 
 /// IMDDimension as shared pointer.
-typedef boost::shared_ptr<Mantid::Geometry::IMDDimension> Dimension_sptr;
+using Dimension_sptr = boost::shared_ptr<Mantid::Geometry::IMDDimension>;
 
 /// IMDDimension as const shared pointer. Note that IMDDimension is pure
 /// virtual.
-typedef boost::shared_ptr<const Mantid::Geometry::IMDDimension>
-    Dimension_const_sptr;
+using Dimension_const_sptr =
+    boost::shared_ptr<const Mantid::Geometry::IMDDimension>;
 
 std::string makeAxisTitle(const Mantid::Geometry::IMDDimension &dim);
 

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/Normalization.h

@@ -37,7 +37,7 @@ enum VisualNormalization {
 };
 
 // Helper typedef
-typedef Mantid::signal_t (Mantid::API::IMDNode::*NormFuncIMDNodePtr)() const;
+using NormFuncIMDNodePtr = Mantid::signal_t (Mantid::API::IMDNode::*)() const;
 
 /**
 Determine which normalization function will be called on an IMDNode
@@ -56,4 +56,4 @@ createIteratorWithNormalization(const VisualNormalization normalizationOption,
 }
 }
 
-#endif /*MANTID_VATES_NORMALIZATION_H_*/
+#endif /*MANTID_VATES_NORMALIZATION_H_*/
\ No newline at end of file

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/PeaksPresenterVsi.h

@@ -29,8 +29,8 @@ public:
                                   const bool ascending) = 0;
 };
 
-typedef boost::shared_ptr<PeaksPresenterVsi> PeaksPresenterVsi_sptr;
-typedef boost::shared_ptr<const PeaksPresenterVsi> PeaksPresenterVsi_const_sptr;
+using PeaksPresenterVsi_sptr = boost::shared_ptr<PeaksPresenterVsi>;
+using PeaksPresenterVsi_const_sptr = boost::shared_ptr<const PeaksPresenterVsi>;
 }
 }
-#endif
+#endif
\ No newline at end of file

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/ViewFrustum.h

@@ -47,12 +47,12 @@ private:
   enum { m_location = I };
 };
 
-typedef FrustumPlane<LEFTPLANE, double> LeftPlane;
-typedef FrustumPlane<RIGHTPLANE, double> RightPlane;
-typedef FrustumPlane<BOTTOMPLANE, double> BottomPlane;
-typedef FrustumPlane<TOPPLANE, double> TopPlane;
-typedef FrustumPlane<FARPLANE, double> FarPlane;
-typedef FrustumPlane<NEARPLANE, double> NearPlane;
+using LeftPlane = FrustumPlane<LEFTPLANE, double>;
+using RightPlane = FrustumPlane<RIGHTPLANE, double>;
+using BottomPlane = FrustumPlane<BOTTOMPLANE, double>;
+using TopPlane = FrustumPlane<TOPPLANE, double>;
+using FarPlane = FrustumPlane<FARPLANE, double>;
+using NearPlane = FrustumPlane<NEARPLANE, double>;
 
 class DLLExport ViewFrustum {
 public:
@@ -156,9 +156,9 @@ void ViewFrustum::initializeMatrix(Mantid::Kernel::Matrix<T> &matrix,
 }
 
 /// shared pointer to the view frustum
-typedef boost::shared_ptr<Mantid::VATES::ViewFrustum> ViewFrustum_sptr;
-typedef boost::shared_ptr<const Mantid::VATES::ViewFrustum>
-    ViewFrustum_const_sptr;
+using ViewFrustum_sptr = boost::shared_ptr<Mantid::VATES::ViewFrustum>;
+using ViewFrustum_const_sptr =
+    boost::shared_ptr<const Mantid::VATES::ViewFrustum>;
 }
 }
-#endif
+#endif
\ No newline at end of file

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/vtkDataSetFactory.h

@@ -247,8 +247,8 @@ private:
   bool m_bCheckDimensionality;
 };
 
-typedef boost::shared_ptr<vtkDataSetFactory> vtkDataSetFactory_sptr;
-typedef std::unique_ptr<vtkDataSetFactory> vtkDataSetFactory_uptr;
+using vtkDataSetFactory_sptr = boost::shared_ptr<vtkDataSetFactory>;
+using vtkDataSetFactory_uptr = std::unique_ptr<vtkDataSetFactory>;
 }
 }
 

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/vtkMDHistoHex4DFactory.h

@@ -74,11 +74,9 @@ protected:
   void validate() const override;
 
 private:
-  typedef std::vector<std::vector<std::vector<UnstructuredPoint>>> PointMap;
-
-  typedef std::vector<std::vector<UnstructuredPoint>> Plane;
-
-  typedef std::vector<UnstructuredPoint> Column;
+  using PointMap = std::vector<std::vector<std::vector<UnstructuredPoint>>>;
+  using Plane = std::vector<std::vector<UnstructuredPoint>>;
+  using Column = std::vector<UnstructuredPoint>;
 
   /// timestep obtained from framework.
   double m_timestep;

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/vtkMDHistoLineFactory.h

@@ -59,7 +59,7 @@ public:
 
   void initialize(const Mantid::API::Workspace_sptr &workspace) override;
 
-  typedef std::vector<UnstructuredPoint> Column;
+  using Column = std::vector<UnstructuredPoint>;
 
   std::string getFactoryTypeName() const override {
     return "vtkMDHistoLineFactory";

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/vtkMDHistoQuadFactory.h

@@ -62,9 +62,9 @@ public:
 
   void initialize(const Mantid::API::Workspace_sptr &workspace) override;
 
-  typedef std::vector<std::vector<UnstructuredPoint>> Plane;
+  using Plane = std::vector<std::vector<UnstructuredPoint>>;
 
-  typedef std::vector<UnstructuredPoint> Column;
+  using Column = std::vector<UnstructuredPoint>;
 
   std::string getFactoryTypeName() const override {
     return "vtkMDHistoQuadFactory";

qt/paraview_ext/VatesAPI/inc/MantidVatesAPI/vtkSplatterPlotFactory.h

@@ -18,8 +18,7 @@
 namespace Mantid {
 namespace VATES {
 
-// Helper typedef
-typedef Mantid::signal_t (Mantid::API::IMDNode::*SigFuncIMDNodePtr)() const;
+using SigFuncIMDNodePtr = Mantid::signal_t (Mantid::API::IMDNode::*)() const;
 
 /**
  * Factory that creates a simple "splatter plot" data set composed of points

qt/paraview_ext/VatesAPI/test/FilteringUpdateProgressActionTest.h

@@ -18,8 +18,8 @@ private:
     }
   };
 
-  typedef Mantid::VATES::FilterUpdateProgressAction<MockFilter>
-      ProgressActionType;
+  using ProgressActionType =
+      Mantid::VATES::FilterUpdateProgressAction<MockFilter>;
 
 public:
   void testCallsView() {
@@ -49,4 +49,4 @@ public:
         "message", view.Message);
   }
 };
-#endif
+#endif
\ No newline at end of file

qt/paraview_ext/VatesAPI/test/MDEWLoadingPresenterTest.h

@@ -33,7 +33,7 @@ private:
   */
   class ConcreteMDEWLoadingPresenter : public MDEWLoadingPresenter {
   private:
-    typedef MDEWLoadingPresenter BaseClass;
+    using BaseClass = MDEWLoadingPresenter;
 
   public:
     void

qt/paraview_ext/VatesAPI/test/MDHWLoadingPresenterTest.h

@@ -31,7 +31,7 @@ private:
   */
   class ConcreteMDHWLoadingPresenter : public MDHWLoadingPresenter {
   private:
-    typedef MDHWLoadingPresenter BaseClass;
+    using BaseClass = MDHWLoadingPresenter;
 
   public:
     ConcreteMDHWLoadingPresenter(std::unique_ptr<MDLoadingView> view)

qt/paraview_ext/VatesSimpleGui/ViewWidgets/inc/MantidVatesSimpleGuiViewWidgets/VsiApplyBehaviour.h

@@ -13,7 +13,7 @@ namespace SimpleGui {
 class VsiApplyBehaviour : public pqApplyBehavior {
 public:
   Q_OBJECT
-  typedef QObject Superclass;
+  using Superclass = QObject;
 
 public:
   VsiApplyBehaviour(Mantid::VATES::ColorScaleLock *lock,

qt/paraview_ext/VatesSimpleGui/ViewWidgets/inc/MantidVatesSimpleGuiViewWidgets/pqCameraReactionNonOrthogonalAxes.h

@@ -71,7 +71,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 class EXPORT_OPT_MANTIDVATES_SIMPLEGUI_VIEWWIDGETS
     pqCameraReactionNonOrthogonalAxes : public pqReaction {
   Q_OBJECT
-  typedef pqReaction Superclass;
+  using Superclass = pqReaction;
 
 public:
   enum Mode {

qt/paraview_ext/VatesSimpleGui/ViewWidgets/inc/MantidVatesSimpleGuiViewWidgets/pqCameraToolbarNonOrthogonalAxes.h

@@ -72,7 +72,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 class EXPORT_OPT_MANTIDVATES_SIMPLEGUI_VIEWWIDGETS
     pqCameraToolbarNonOrthogonalAxes : public QToolBar {
   Q_OBJECT
-  typedef QToolBar Superclass;
+  using Superclass = QToolBar;
 
 public:
   pqCameraToolbarNonOrthogonalAxes(const QString &title,

qt/scientific_interfaces/ISISReflectometry/MeasurementItem.h

@@ -33,7 +33,7 @@ namespace CustomInterfaces {
 class MANTIDQT_ISISREFLECTOMETRY_DLL MeasurementItem {
 
 public:
-  typedef std::string IDType;
+  using IDType = std::string;
 
   /// Constructor
   MeasurementItem(const IDType &measurementItemId, const IDType &subId,

qt/scientific_interfaces/ISISReflectometry/ReflMeasureTransferStrategy.cpp

@@ -43,9 +43,9 @@ TransferResults
 MantidQt::CustomInterfaces::ReflMeasureTransferStrategy::transferRuns(
     SearchResultMap &searchResults, Mantid::Kernel::ProgressBase &progress) {
 
-  typedef std::vector<MeasurementItem> VecSameMeasurement;
-  typedef std::map<MeasurementItem::IDType, VecSameMeasurement>
-      MapGroupedMeasurement;
+  using VecSameMeasurement = std::vector<MeasurementItem>;
+  using MapGroupedMeasurement =
+      std::map<MeasurementItem::IDType, VecSameMeasurement>;
 
   // table-like output for successful runs
   std::vector<std::map<std::string, std::string>> runs;

qt/scientific_interfaces/ISISReflectometry/ReflSearchModel.h

@@ -72,7 +72,7 @@ protected:
 };
 
 /// Typedef for a shared pointer to \c ReflSearchModel
-typedef boost::shared_ptr<ReflSearchModel> ReflSearchModel_sptr;
+using ReflSearchModel_sptr = boost::shared_ptr<ReflSearchModel>;
 
 } // namespace CustomInterfaces
 } // namespace Mantid

qt/scientific_interfaces/ISISReflectometry/ReflTableSchema.h

@@ -9,10 +9,10 @@ namespace MantidQt {
 namespace CustomInterfaces {
 namespace ReflTableSchema {
 
-typedef std::string ColumnNameType;
-typedef std::string ColumnValueType;
-typedef std::map<int, ColumnNameType> ColumnIndexNameMap;
-typedef std::map<ColumnNameType, int> ColumnNameIndexMap;
+using ColumnNameType = std::string;
+using ColumnValueType = std::string;
+using ColumnIndexNameMap = std::map<int, ColumnNameType>;
+using ColumnNameIndexMap = std::map<ColumnNameType, int>;
 
 /// Label for run number column
 static const std::string RUNS("Run(s)");

qt/scientific_interfaces/ISISReflectometry/ReflTransferStrategy.h

@@ -29,7 +29,7 @@ struct SearchResult {
 };
 
 /// Helper typdef for map of SearchResults keyed by run
-typedef std::map<std::string, SearchResult> SearchResultMap;
+using SearchResultMap = std::map<std::string, SearchResult>;
 
 /** ReflTransferStrategy : Provides an stratgegy for transferring runs from
 search results to a format suitable for processing.