Changed iterator to be a random access iterator

re #23145

Framework/Geometry/inc/MantidGeometry/Instrument/DetectorInfoIterator.h

@@ -45,7 +45,7 @@ Code Documentation is available at: <http://doxygen.mantidproject.org>
 class MANTID_GEOMETRY_DLL DetectorInfoIterator
     : public boost::iterator_facade<DetectorInfoIterator,
                                     const DetectorInfoItem &,
-                                    boost::bidirectional_traversal_tag> {
+                                    boost::random_access_traversal_tag> {
 
 public:
   DetectorInfoIterator(const DetectorInfo &detectorInfo, const size_t index)

Framework/Geometry/test/DetectorInfoIteratorTest.h

@@ -151,8 +151,8 @@ public:
     std::advance(iter, -2);
     TS_ASSERT_EQUALS(iter->getIndex(), 9);
 
-    // Go past the start
-    std::advance(iter, -100);
+    // Go to the start
+    std::advance(iter, -9);
     TS_ASSERT(iter == detectorInfo->begin());
   }
 

Framework/PythonInterface/mantid/geometry/src/Exports/DetectorInfo.cpp

@@ -26,7 +26,7 @@ using namespace boost::python;
 // Helper method to make the python iterator
 DetectorInfoPythonIterator make_pyiterator(const DetectorInfo &detectorInfo) {
   return DetectorInfoPythonIterator(detectorInfo);
-};
+}
 
 // Export DetectorInfo
 void export_DetectorInfo() {