Accept OrientedLattice by unique_ptr
The overwhelming use case for this method is to take ownership of a lattice object into Sample. Using unique_ptr clarifies that this is happening at the call site and forces a caller to make copy if that is truly the desired behaviour. The old code make a copy internally but this was not obvious from the method call.
Showing
- Framework/API/inc/MantidAPI/Sample.h 3 additions, 5 deletionsFramework/API/inc/MantidAPI/Sample.h
- Framework/API/src/Sample.cpp 4 additions, 6 deletionsFramework/API/src/Sample.cpp
- Framework/API/test/ExperimentInfoTest.h 6 additions, 6 deletionsFramework/API/test/ExperimentInfoTest.h
- Framework/API/test/MatrixWorkspaceTest.h 2 additions, 3 deletionsFramework/API/test/MatrixWorkspaceTest.h
- Framework/API/test/MultipleExperimentInfosTest.h 2 additions, 5 deletionsFramework/API/test/MultipleExperimentInfosTest.h
- Framework/API/test/OrientedLatticeValidatorTest.h 2 additions, 2 deletionsFramework/API/test/OrientedLatticeValidatorTest.h
- Framework/API/test/SampleTest.h 23 additions, 30 deletionsFramework/API/test/SampleTest.h
- Framework/Algorithms/src/CopySample.cpp 5 additions, 2 deletionsFramework/Algorithms/src/CopySample.cpp
- Framework/Algorithms/test/CopySampleTest.h 4 additions, 6 deletionsFramework/Algorithms/test/CopySampleTest.h
- Framework/Crystal/src/CalculateUMatrix.cpp 4 additions, 4 deletionsFramework/Crystal/src/CalculateUMatrix.cpp
- Framework/Crystal/src/FindUBUsingFFT.cpp 6 additions, 8 deletionsFramework/Crystal/src/FindUBUsingFFT.cpp
- Framework/Crystal/src/FindUBUsingIndexedPeaks.cpp 10 additions, 10 deletionsFramework/Crystal/src/FindUBUsingIndexedPeaks.cpp
- Framework/Crystal/src/FindUBUsingLatticeParameters.cpp 11 additions, 11 deletionsFramework/Crystal/src/FindUBUsingLatticeParameters.cpp
- Framework/Crystal/src/FindUBUsingMinMaxD.cpp 6 additions, 8 deletionsFramework/Crystal/src/FindUBUsingMinMaxD.cpp
- Framework/Crystal/src/GoniometerAnglesFromPhiRotation.cpp 8 additions, 8 deletionsFramework/Crystal/src/GoniometerAnglesFromPhiRotation.cpp
- Framework/Crystal/src/LoadIsawUB.cpp 5 additions, 5 deletionsFramework/Crystal/src/LoadIsawUB.cpp
- Framework/Crystal/src/OptimizeLatticeForCellType.cpp 13 additions, 12 deletionsFramework/Crystal/src/OptimizeLatticeForCellType.cpp
- Framework/Crystal/src/PredictSatellitePeaks.cpp 28 additions, 29 deletionsFramework/Crystal/src/PredictSatellitePeaks.cpp
- Framework/Crystal/src/SelectCellOfType.cpp 9 additions, 8 deletionsFramework/Crystal/src/SelectCellOfType.cpp
- Framework/Crystal/src/SelectCellWithForm.cpp 9 additions, 8 deletionsFramework/Crystal/src/SelectCellWithForm.cpp
Loading
Please register or sign in to comment