Apply change from clang-tidy: modernize-use-default.

Framework/API/inc/MantidAPI/HistoryItem.h

@@ -43,7 +43,8 @@ namespace API {
 class MANTID_API_DLL HistoryItem {
 public:
   HistoryItem(AlgorithmHistory_const_sptr algHist);
-  virtual ~HistoryItem(){};
+  virtual ~HistoryItem() = default;
+  ;
   bool isUnrolled() const { return m_unrolled; }
   void unrolled(bool unrolled) { m_unrolled = unrolled; }
   AlgorithmHistory_const_sptr getAlgorithmHistory() const {

Framework/API/inc/MantidAPI/IFileLoader.h

@@ -37,9 +37,6 @@ Code Documentation is available at: <http://doxygen.mantidproject.org>
 template <typename DescriptorType>
 class MANTID_API_DLL IFileLoader : public Algorithm {
 public:
-  /// Virtual destructor (required by linker on some versions of OS X/Intel
-  /// compiler)
-  ~IFileLoader() override {}
   /// Returns a confidence value that this algorithm can load a file
   virtual int confidence(DescriptorType &descriptor) const = 0;
   /// Returns a value indicating whether or not loader wants to load multiple

Framework/API/inc/MantidAPI/IFunctionWithLocation.h

@@ -45,7 +45,7 @@ public:
   /// Virtual destructor
   /// (avoids warnings about non-trivial move assignment in virtually inheriting
   /// classes)
-  ~IFunctionWithLocation() override {}
+  ~IFunctionWithLocation() override = default;
 
   /// Returns the centre of the function, which may be something as simple as
   /// the centre of

Framework/API/src/AlgorithmFactory.cpp

@@ -25,7 +25,7 @@ AlgorithmFactoryImpl::AlgorithmFactoryImpl()
   g_log.debug() << "Algorithm Factory created." << std::endl;
 }
 
-AlgorithmFactoryImpl::~AlgorithmFactoryImpl() {}
+AlgorithmFactoryImpl::~AlgorithmFactoryImpl() = default;
 
 /** Creates an instance of an algorithm
 * @param name :: the name of the Algrorithm to create

Framework/API/src/AlgorithmManager.cpp

@@ -29,7 +29,7 @@ AlgorithmManagerImpl::AlgorithmManagerImpl() : m_managed_algs() {
 *  Prevents client from calling 'delete' on the pointer handed
 *  out by Instance
 */
-AlgorithmManagerImpl::~AlgorithmManagerImpl() {}
+AlgorithmManagerImpl::~AlgorithmManagerImpl() = default;
 
 /** Creates an instance of an algorithm, but does not own that instance
 *

Framework/API/src/AlgorithmObserver.cpp

@@ -30,7 +30,7 @@ AlgorithmObserver::AlgorithmObserver(IAlgorithm_const_sptr alg)
 }
 
 /// Virtual destructor
-AlgorithmObserver::~AlgorithmObserver() {}
+AlgorithmObserver::~AlgorithmObserver() = default;
 
 /**   Connect to algorithm alg and observe all its notifications
       @param alg :: Algorithm to be observed

Framework/API/src/AlgorithmProperty.cpp

@@ -44,7 +44,7 @@ AlgorithmProperty &AlgorithmProperty::operator=(const AlgorithmProperty &rhs) {
 /**
  * Destructor
  */
-AlgorithmProperty::~AlgorithmProperty() {}
+AlgorithmProperty::~AlgorithmProperty() = default;
 
 /**
  * Return the algorithm as string

Framework/API/src/DataProcessorAlgorithm.cpp

@@ -36,7 +36,7 @@ DataProcessorAlgorithm::DataProcessorAlgorithm()
 //----------------------------------------------------------------------------------------------
 /** Destructor
  */
-DataProcessorAlgorithm::~DataProcessorAlgorithm() {}
+DataProcessorAlgorithm::~DataProcessorAlgorithm() = default;
 
 //---------------------------------------------------------------------------------------------
 /** Create a Child Algorithm.  A call to this method creates a child algorithm

Framework/API/src/DeprecatedAlgorithm.cpp

@@ -16,7 +16,7 @@ DeprecatedAlgorithm::DeprecatedAlgorithm()
     : m_replacementAlgorithm(), m_replacementVersion(-1), m_deprecatedDate() {}
 
 /// Does nothing other than make the compiler happy.
-DeprecatedAlgorithm::~DeprecatedAlgorithm() {}
+DeprecatedAlgorithm::~DeprecatedAlgorithm() = default;
 
 /// The algorithm to use instead of this one.
 /// @param replacement Name of the algorithm that replaces the deprecated one

Framework/API/src/FileLoaderRegistry.cpp

@@ -174,7 +174,7 @@ FileLoaderRegistryImpl::FileLoaderRegistryImpl()
 
 /**
  */
-FileLoaderRegistryImpl::~FileLoaderRegistryImpl() {}
+FileLoaderRegistryImpl::~FileLoaderRegistryImpl() = default;
 
 /**
  * @param name A string containing the algorithm name

Framework/API/src/FrameworkManager.cpp

@@ -83,7 +83,7 @@ FrameworkManagerImpl::FrameworkManagerImpl()
 }
 
 /// Destructor
-FrameworkManagerImpl::~FrameworkManagerImpl() {}
+FrameworkManagerImpl::~FrameworkManagerImpl() = default;
 
 /// Starts asynchronous tasks that are done as part of Start-up.
 void FrameworkManagerImpl::AsynchronousStartupTasks() {

Framework/API/src/GroupingLoader.cpp

@@ -34,7 +34,7 @@ GroupingLoader::GroupingLoader(Geometry::Instrument_const_sptr instrument,
 //----------------------------------------------------------------------------------------------
 /** Destructor
  */
-GroupingLoader::~GroupingLoader() {}
+GroupingLoader::~GroupingLoader() = default;
 
 /**
  * Attempts to load a grouping information referenced by IDF.

Framework/API/src/MultiPeriodGroupAlgorithm.cpp

@@ -15,7 +15,7 @@ MultiPeriodGroupAlgorithm::MultiPeriodGroupAlgorithm()
 //----------------------------------------------------------------------------------------------
 /** Destructor
  */
-MultiPeriodGroupAlgorithm::~MultiPeriodGroupAlgorithm() {}
+MultiPeriodGroupAlgorithm::~MultiPeriodGroupAlgorithm() = default;
 
 /** Check the input workspace properties for groups.
  *

Framework/API/src/MultiPeriodGroupWorker.cpp

@@ -28,7 +28,7 @@ MultiPeriodGroupWorker::MultiPeriodGroupWorker(
 //----------------------------------------------------------------------------------------------
 /** Destructor
  */
-MultiPeriodGroupWorker::~MultiPeriodGroupWorker() {}
+MultiPeriodGroupWorker::~MultiPeriodGroupWorker() = default;
 
 /**
  * Try to add the input workspace to the multiperiod input group list.

Framework/API/src/Progress.cpp

@@ -40,7 +40,7 @@ Progress::Progress(Algorithm *alg, double start, double end, size_t numSteps)
     : ProgressBase(start, end, int64_t(numSteps)), m_alg(alg) {}
 
 /** Destructor */
-Progress::~Progress() {}
+Progress::~Progress() = default;
 
 /** Actually do the reporting, without changing the loop counter.
  * This is called by report(), and can be called directly in

Framework/Crystal/inc/MantidCrystal/AnvredCorrection.h

@@ -77,8 +77,6 @@ class DLLExport AnvredCorrection : public API::Algorithm {
 public:
   /// (Empty) Constructor
   AnvredCorrection();
-  /// Virtual destructor
-  ~AnvredCorrection() override {}
   /// Algorithm's name for identification overriding a virtual method
   const std::string name() const override { return "AnvredCorrection"; }
   /// Summary of algorithms purpose

Framework/Crystal/inc/MantidCrystal/FindSXPeaks.h

@@ -193,8 +193,6 @@ class DLLExport FindSXPeaks : public API::Algorithm {
 public:
   /// Default constructor
   FindSXPeaks();
-  /// Destructor
-  ~FindSXPeaks() override{};
   /// Algorithm's name for identification overriding a virtual method
   const std::string name() const override { return "FindSXPeaks"; }
   /// Summary of algorithms purpose

Framework/Crystal/inc/MantidCrystal/IndexSXPeaks.h

@@ -153,10 +153,6 @@ private:
 
 class DLLExport IndexSXPeaks : public API::Algorithm {
 public:
-  /// Default constructor
-  IndexSXPeaks() : API::Algorithm(){};
-  /// Destructor
-  ~IndexSXPeaks() override{};
   /// Algorithm's name for identification overriding a virtual method
   const std::string name() const override { return "IndexSXPeaks"; }
   /// Summary of algorithms purpose

Framework/Crystal/inc/MantidCrystal/NormaliseVanadium.h

@@ -49,8 +49,6 @@ class DLLExport NormaliseVanadium : public API::Algorithm {
 public:
   /// (Empty) Constructor
   NormaliseVanadium();
-  /// Virtual destructor
-  ~NormaliseVanadium() override {}
   /// Algorithm's name for identification overriding a virtual method
   const std::string name() const override { return "NormaliseVanadium"; }
   /// Summary of algorithms purpose

Framework/Crystal/src/AddPeakHKL.cpp

@@ -23,7 +23,7 @@ AddPeakHKL::AddPeakHKL() {}
 //----------------------------------------------------------------------------------------------
 /** Destructor
  */
-AddPeakHKL::~AddPeakHKL() {}
+AddPeakHKL::~AddPeakHKL() = default;
 
 //----------------------------------------------------------------------------------------------