Re #14390 LoadingPresenters take ownership of view - change signature
The xxxLoadingPresenter objects take a raw pointer to a view in their constructor, and then delete it in their destructor. This is confusing to the caller. Replace the raw pointer with a unique_ptr - the presenters now take ownership of a unique_ptr and this is much clearer. Updated all calls in VatesAPI and tests.
Showing
- Vates/VatesAPI/inc/MantidVatesAPI/EventNexusLoadingPresenter.h 5 additions, 2 deletions.../VatesAPI/inc/MantidVatesAPI/EventNexusLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDEWEventNexusLoadingPresenter.h 5 additions, 2 deletions...esAPI/inc/MantidVatesAPI/MDEWEventNexusLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDEWInMemoryLoadingPresenter.h 3 additions, 1 deletion...atesAPI/inc/MantidVatesAPI/MDEWInMemoryLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDEWLoadingPresenter.h 2 additions, 2 deletionsVates/VatesAPI/inc/MantidVatesAPI/MDEWLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDHWInMemoryLoadingPresenter.h 1 addition, 1 deletion...atesAPI/inc/MantidVatesAPI/MDHWInMemoryLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDHWLoadingPresenter.h 1 addition, 1 deletionVates/VatesAPI/inc/MantidVatesAPI/MDHWLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/MDHWNexusLoadingPresenter.h 1 addition, 1 deletion...s/VatesAPI/inc/MantidVatesAPI/MDHWNexusLoadingPresenter.h
- Vates/VatesAPI/inc/MantidVatesAPI/SQWLoadingPresenter.h 2 additions, 1 deletionVates/VatesAPI/inc/MantidVatesAPI/SQWLoadingPresenter.h
- Vates/VatesAPI/src/EventNexusLoadingPresenter.cpp 47 additions, 55 deletionsVates/VatesAPI/src/EventNexusLoadingPresenter.cpp
- Vates/VatesAPI/src/MDEWEventNexusLoadingPresenter.cpp 33 additions, 37 deletionsVates/VatesAPI/src/MDEWEventNexusLoadingPresenter.cpp
- Vates/VatesAPI/src/MDEWInMemoryLoadingPresenter.cpp 35 additions, 38 deletionsVates/VatesAPI/src/MDEWInMemoryLoadingPresenter.cpp
- Vates/VatesAPI/src/MDEWLoadingPresenter.cpp 56 additions, 64 deletionsVates/VatesAPI/src/MDEWLoadingPresenter.cpp
- Vates/VatesAPI/src/MDHWInMemoryLoadingPresenter.cpp 4 additions, 3 deletionsVates/VatesAPI/src/MDHWInMemoryLoadingPresenter.cpp
- Vates/VatesAPI/src/MDHWLoadingPresenter.cpp 4 additions, 3 deletionsVates/VatesAPI/src/MDHWLoadingPresenter.cpp
- Vates/VatesAPI/src/MDHWNexusLoadingPresenter.cpp 6 additions, 6 deletionsVates/VatesAPI/src/MDHWNexusLoadingPresenter.cpp
- Vates/VatesAPI/src/SQWLoadingPresenter.cpp 21 additions, 19 deletionsVates/VatesAPI/src/SQWLoadingPresenter.cpp
- Vates/VatesAPI/test/EventNexusLoadingPresenterTest.h 43 additions, 23 deletionsVates/VatesAPI/test/EventNexusLoadingPresenterTest.h
- Vates/VatesAPI/test/MDEWEventNexusLoadingPresenterTest.h 60 additions, 33 deletionsVates/VatesAPI/test/MDEWEventNexusLoadingPresenterTest.h
- Vates/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h 60 additions, 28 deletionsVates/VatesAPI/test/MDEWInMemoryLoadingPresenterTest.h
- Vates/VatesAPI/test/MDEWLoadingPresenterTest.h 3 additions, 4 deletionsVates/VatesAPI/test/MDEWLoadingPresenterTest.h
Loading
Please register or sign in to comment