Skip to content
Snippets Groups Projects
Commit 0683893b authored by Harriet Brown's avatar Harriet Brown
Browse files

Apply Changes from code review

This commit corrects typos in the ISISPowder-Polaris documentation, It also replaces a print statement in Polaris with a logger.warning.
parent c7a4b57d
No related merge requests found
......@@ -168,9 +168,9 @@ The *create_total_scattering_pdf* method allows a user to create a Pair Distribu
from focused POLARIS data, with a view performing further total scattering analysis.
With no merging criteria specified, *merge_banks=False* a PDF will be generated for each bank within
the focused_workspace. The type of PDF output can be set with the kayword argument `pdf_type`, with the
the focused_workspace. The type of PDF output can be set with the keyword argument `pdf_type`, with the
option of `G(r)`, `g(r)`, `RDF(r)` (defaults to `G(r)`). If run with *merge_banks=True* a PDF will be
generated based on the wighted sum of the detector banks performed using supplied Q limits
generated based on the weighted sum of the detector banks performed using supplied Q limits
*q_lims=q_limits*, Q_limits can be in the form of a numpy array with shape (2, x) where x is the number
of detectors, or a string containing the directory of an appropriately formatted `.lim` file.
......
......@@ -10,6 +10,7 @@ import os
from isis_powder.routines import absorb_corrections, common, instrument_settings
from isis_powder.abstract_inst import AbstractInst
from isis_powder.polaris_routines import polaris_advanced_config, polaris_algs, polaris_param_mapping
from mantid.kernel import logger
class Polaris(AbstractInst):
......@@ -53,7 +54,7 @@ class Polaris(AbstractInst):
kwargs['q_lims'] = None
if 'pdf_type' not in kwargs or not kwargs['pdf_type'] in ['G(r)', 'g(r)', 'RDF(r)']:
kwargs['pdf_type'] = 'G(r)'
print('PDF type not specified or is invalid, defaulting to G(r)')
logger.warning('PDF type not specified or is invalid, defaulting to G(r)')
self._inst_settings.update_attributes(kwargs=kwargs)
# Generate pdf
run_details = self._get_run_details(self._inst_settings.run_number)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment