Re #15360 fix PeakColumn::getReadOnly and added unit test

Framework/DataObjects/src/PeakColumn.cpp

@@ -206,7 +206,7 @@ void PeakColumn::read(size_t index, const std::string &text) {
 //-------------------------------------------------------------------------------------
 /** @return true if the column is read-only */
 bool PeakColumn::getReadOnly() const {
-  return ((m_name == "h") || (m_name == "k") || (m_name == "l") ||
+  return !((m_name == "h") || (m_name == "k") || (m_name == "l") ||
           (m_name == "RunNumber"));
 }
 

Framework/DataObjects/test/PeakColumnTest.h

@@ -106,6 +106,16 @@ public:
     TS_ASSERT_EQUALS(qlab1, m_peaks[1].getQLabFrame());
   }
 
+  void test_get_read_only_returns_correct_value() {
+	  PeakColumn pc1(m_peaks, "h");
+	  auto readOnly = pc1.getReadOnly();
+	  TS_ASSERT(!readOnly);
+
+	  PeakColumn pc2(m_peaks, "DetID");
+	  readOnly = pc2.getReadOnly();
+	  TS_ASSERT(readOnly);
+  }
+
 private:
   Mantid::Geometry::Instrument_sptr m_inst;
   std::vector<Peak> m_peaks;