Skip to content
Snippets Groups Projects
  • Martyn Gigg's avatar
    904e41e5
    Revert (but cleanup) SingletonHolder implementation · 904e41e5
    Martyn Gigg authored
    MSVC 2017 15.7 contains a bug where constant initialization no longer
    takes place for objects with constructors marked constexpr such as
    once_flag. This leaves once_flag susceptible to dynamic initialization
    order problems and causes some singleton instances to be constructed
    incorrectly. We put back our correct implementation (with some cleanup)
    and await a fix from MS.
    Refs #0
    904e41e5
    History
    Revert (but cleanup) SingletonHolder implementation
    Martyn Gigg authored
    MSVC 2017 15.7 contains a bug where constant initialization no longer
    takes place for objects with constructors marked constexpr such as
    once_flag. This leaves once_flag susceptible to dynamic initialization
    order problems and causes some singleton instances to be constructed
    incorrectly. We put back our correct implementation (with some cleanup)
    and await a fix from MS.
    Refs #0
Code owners
Assign users and groups as approvers for specific file changes. Learn more.