Skip to content
Snippets Groups Projects
  • Adam J. Jackson's avatar
    7c26355b
    Abins interpolated broadening: tolerate direction changes in sigma · 7c26355b
    Adam J. Jackson authored
    The initial implementation assumed that the input series of sigma
    values would monotonically increase, which is reasonable for TOSCA but
    not for other instruments.
    
    The logic is modified so that instead of
    the input data, the list of sigma values used for convolution is
    required to be sorted. As this list was generated within the same
    function and ranges from (min(sigma), max(sigma)), the condition is
    always satisfied.
    
    The unit tests are not affected, but there may be a small numerical
    difference as another implementation detail has been fixed in the
    process; the interpolation x-values ('sigma factors') should be the
    ratio between sigma and sigma at the lower bound of the current
    window. In the initial implementation this was mistakenly identified
    as sigma_chunk[0], the left-most value in the block _out of the actual
    sigma values_; it should be the exact convolved width from `sigma_samples`.
    7c26355b
    History
    Abins interpolated broadening: tolerate direction changes in sigma
    Adam J. Jackson authored
    The initial implementation assumed that the input series of sigma
    values would monotonically increase, which is reasonable for TOSCA but
    not for other instruments.
    
    The logic is modified so that instead of
    the input data, the list of sigma values used for convolution is
    required to be sorted. As this list was generated within the same
    function and ranges from (min(sigma), max(sigma)), the condition is
    always satisfied.
    
    The unit tests are not affected, but there may be a small numerical
    difference as another implementation detail has been fixed in the
    process; the interpolation x-values ('sigma factors') should be the
    ratio between sigma and sigma at the lower bound of the current
    window. In the initial implementation this was mistakenly identified
    as sigma_chunk[0], the left-most value in the block _out of the actual
    sigma values_; it should be the exact convolved width from `sigma_samples`.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.