Commit 8bb6c8a2 authored by Huihui Zhang's avatar Huihui Zhang
Browse files

[AMDGPU] Fix data race on RegisterBank initialization. 

Summary:
The initialization of RegisterBank needs to be done only once. The
logic of AlreadyInit has data race, use llvm::call_once instead.

This is continuing work of D73587.

Reviewers: arsenm, tstellar, ronlieb, efriedma, apazos, nhaehnle

Reviewed By: nhaehnle

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, kerbowa, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73604
parent a5a4a47d

llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

+7 −7
Original line number Diff line number Diff line
@@ -197,15 +197,15 @@ AMDGPURegisterBankInfo::AMDGPURegisterBankInfo(const GCNSubtarget &ST) 
      TII(Subtarget.getInstrInfo()) {



  // HACK: Until this is fully tablegen'd.

  static bool AlreadyInit = false;

  if (AlreadyInit)

    return;



  AlreadyInit = true;

  static llvm::once_flag InitializeRegisterBankFlag;



  static auto InitializeRegisterBankOnce = [this]() {

    assert(&getRegBank(AMDGPU::SGPRRegBankID) == &AMDGPU::SGPRRegBank &&

           &getRegBank(AMDGPU::VGPRRegBankID) == &AMDGPU::VGPRRegBank &&

           &getRegBank(AMDGPU::AGPRRegBankID) == &AMDGPU::AGPRRegBank);

  };



  llvm::call_once(InitializeRegisterBankFlag, InitializeRegisterBankOnce);

}



static bool isVectorRegisterBank(const RegisterBank &Bank) {