fixed off by one error in index end calculation

Note, this could also likely be:

return Index( array_size, _num_soa+1, 0);

or similar as you prefer.

There's probably even something better that can be done, but I wanted to offer a solution rather than dump an issue on you on the way out the door!

core/src/Cabana_AoSoA.hpp

@@ -255,7 +255,10 @@ class AoSoA<MemberDataTypes<Types...>,Device,ArraySize>
     CABANA_FUNCTION
     Index end() const
     {
-        return Index( array_size, _num_soa - 1, _size % array_size );
+        std::size_t remainder = _size % array_size;
+        std::size_t s = ( 0 == remainder ) ? _num_soa : _num_soa - 1;
+        std::size_t i = ( 0 == remainder ) ? 0 : remainder;
+        return Index( array_size, s, i );
     }
 
     // -------------------------------