Commit f43b0f38 authored by Simon Spannagel's avatar Simon Spannagel
Browse files

Move of const or trivially-copyable type has no effect

parent 73c183ff

src/core/geometry/Detector.cpp

+1 −1
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ Pixel Detector::getPixel(const Pixel::Index& index) const { 
    auto local_center = model_->getPixelCenter(index.x(), index.y());

    auto global_center = getGlobalPosition(local_center);



    return {std::move(index), std::move(type), std::move(local_center), std::move(global_center), std::move(size)};

    return {index, type, std::move(local_center), std::move(global_center), std::move(size)};

}



/**

src/core/geometry/DetectorModel.cpp

+2 −2
Original line number Diff line number Diff line
@@ -174,8 +174,8 @@ void DetectorModel::addImplant(const Implant::Type& type, 
    // Calculate offset from sensor center - sign of the shift depends on whether it's on front- or backside:

    auto offset_z = (getSensorSize().z() - size.z()) / 2. * (type == Implant::Type::FRONTSIDE ? 1 : -1);

    ROOT::Math::XYZVector full_offset(offset.x(), offset.y(), offset_z);

    implants_.push_back(Implant(

        type, shape, std::move(size), std::move(full_offset), ROOT::Math::RotationZ(orientation), std::move(config)));

    implants_.push_back(

        Implant(type, shape, std::move(size), std::move(full_offset), ROOT::Math::RotationZ(orientation), config));

}



void DetectorModel::validate() {