Commit e42fb2f2 authored by Simon Spannagel's avatar Simon Spannagel
Browse files

Add two linter findings

parent a4686875

src/core/geometry/GeometryManager.cpp

+1 −1
Original line number Diff line number Diff line
@@ -392,7 +392,7 @@ void GeometryManager::read_model_file(const std::filesystem::path& path) { 
    try {

        // Try to parse as config file

        std::ifstream file(path);

        ConfigReader reader(file, path);

        const ConfigReader reader(file, path);



        // Parse configuration and add model to the config

        addModel(DetectorModel::factory(model_name, reader));

src/modules/ROOTObjectWriter/ROOTObjectWriterModule.cpp

+1 −1
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ void ROOTObjectWriterModule::initialize() { 


    // Check if the given type of object is contained in the inclusion or exclusion filter rules:

    auto check_object_filter = [](const std::string& object, const std::set<std::string>& arr, bool inclusive) {

        auto contained = std::find(arr.begin(), arr.end(), object);

        auto contained = arr.find(object);

        if((!inclusive && contained == std::end(arr)) || (inclusive && contained != std::end(arr))) {

            LOG(WARNING) << object << (inclusive ? " included" : " not excluded")

                         << ", this will lead to large output files and possible performance penalties";