Commit b29541c2 authored by Håkan Wennlöf's avatar Håkan Wennlöf
Browse files

Merge branch 'b-linter' into 'v3.0-stable' 

[v3.0-stable] Linter update to clang-tidy-16

See merge request allpix-squared/allpix-squared!1093
parents 19aa0810 d3f07736

.clang-tidy

+6 −6
Original line number Diff line number Diff line
@@ -5,13 +5,13 @@ Checks : '-*, 
          boost-*,

          mpi-*,

          performance-*,

          google-*,-google-readability-todo,-google-build-using-namespace,-google-readability-namespace-comments,-google-runtime-references,-google-runtime-int,

          readability-*,-readability-named-parameter,-readability-inconsistent-declaration-parameter-name,-readability-avoid-const-params-in-decls,-readability-simplify-boolean-expr,-readability-redundant-declaration,-readability-else-after-return,-readability-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-const-return-type,-readability-convert-member-functions-to-static,-readability-function-cognitive-complexity,

          google-*,-google-readability-todo,-google-build-using-namespace,-google-readability-namespace-comments,-google-runtime-references,-google-runtime-int,-google-readability-casting,

          readability-*,-readability-named-parameter,-readability-inconsistent-declaration-parameter-name,-readability-avoid-const-params-in-decls,-readability-simplify-boolean-expr,-readability-redundant-declaration,-readability-else-after-return,-readability-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-const-return-type,-readability-convert-member-functions-to-static,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-use-anyofallof,-readability-container-contains,

          llvm-*,-llvm-include-order,-llvm-header-guard,-llvm-namespace-comment,-llvm-qualified-auto,-llvm-else-after-return,

          modernize-*,-modernize-raw-string-literal,-modernize-use-nodiscard,-modernize-use-trailing-return-type,-modernize-avoid-bind,

          cppcoreguidelines-*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-special-member-functions,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-owning-memory,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-macro-usage,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-avoid-non-const-global-variables,

          cert-*,-cert-err58-cpp,-cert-err34-c,-cert-msc51-cpp,-cert-msc32-c,-cert-dcl16-c,-cert-oop54-cpp,

          misc-*,-misc-noexcept-move-constructor,-misc-non-private-member-variables-in-classes,-misc-no-recursion,

          modernize-*,-modernize-raw-string-literal,-modernize-use-nodiscard,-modernize-use-trailing-return-type,-modernize-avoid-bind,-modernize-macro-to-enum,

          cppcoreguidelines-*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-special-member-functions,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-owning-memory,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-macro-usage,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-virtual-class-destructor,-cppcoreguidelines-avoid-const-or-ref-data-members,

          cert-*,-cert-err58-cpp,-cert-err34-c,-cert-msc51-cpp,-cert-msc32-c,-cert-dcl16-c,-cert-oop54-cpp,-cert-err33-c,

          misc-*,-misc-noexcept-move-constructor,-misc-non-private-member-variables-in-classes,-misc-no-recursion,-misc-const-correctness,-misc-use-anonymous-namespace,

          clang-analyzer-*,-clang-analyzer-alpha*,-clang-analyzer-core*,-clang-analyzer-cplusplus*,-clang-analyzer-optin*'

WarningsAsErrors: '*'

HeaderFilterRegex: '*.h *.hpp'

src/core/config/ConfigReader.cpp

+2 −4
Original line number Diff line number Diff line
@@ -225,7 +225,7 @@ Configuration ConfigReader::getHeaderConfiguration() const { 
std::vector<Configuration> ConfigReader::getConfigurations(std::string name) const {

    std::transform(name.begin(), name.end(), name.begin(), ::tolower);

    if(!hasConfiguration(name)) {

        return std::vector<Configuration>();

        return {};

    }



    std::vector<Configuration> result;
@@ -235,6 +235,4 @@ std::vector<Configuration> ConfigReader::getConfigurations(std::string name) con 
    return result;

}



std::vector<Configuration> ConfigReader::getConfigurations() const {

    return std::vector<Configuration>(conf_array_.begin(), conf_array_.end());

}
 
std::vector<Configuration> ConfigReader::getConfigurations() const { return {conf_array_.begin(), conf_array_.end()}; }

src/core/config/Configuration.tpp

+1 −1
Original line number Diff line number Diff line
@@ -79,7 +79,7 @@ namespace allpix { 
        if(has(key)) {

            return getArray<T>(key);

        }

        return def;

        return std::move(def);

    }



    /**

src/core/config/OptionParser.cpp

+1 −1
Original line number Diff line number Diff line
@@ -34,7 +34,7 @@ void OptionParser::parseOption(std::string line) { 
        // Other identifier bound option is passed

        auto identifier = key.substr(0, dot_pos);

        key = key.substr(dot_pos + 1);

        identifier_options_[identifier].push_back(std::make_pair(key, value));

        identifier_options_[identifier].emplace_back(key, value);

    }

}

src/core/geometry/Detector.cpp

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ Detector::Detector(std::string name, 
                   ROOT::Math::XYZPoint position,

                   const ROOT::Math::Rotation3D& orientation)

    : Detector(std::move(name), std::move(position), orientation) {

    model_ = std::move(model);

    model_ = std::move(model); // NOLINT

    // Check if valid model is supplied

    if(model_ == nullptr) {

        throw InvalidModuleActionException("Detector model cannot be a null pointer");