Commit 9d188d5c authored by Paul Schütze's avatar Paul Schütze
Browse files

Merge branch 'backport_char_string' into 'v2.3-stable' 

DepositionReader: fix reading of NULL-terminated char string from ROOT Tree

See merge request allpix-squared/allpix-squared!774
parents d45b1054 d20beca1

src/modules/DepositionReader/DepositionReaderModule.cpp

+7 −11
Original line number Diff line number Diff line
@@ -251,6 +251,12 @@ void DepositionReaderModule::run(Event* event) { 
            break;

        }



        // Trim detector name if requested:

        if(volume_chars_ != 0) {

            volume = volume.substr(0, std::min(volume_chars_, volume.size()));

            LOG(TRACE) << "Truncated detector name: " << volume;

        }



        auto detectors = geo_manager_->getDetectors();

        auto pos = std::find_if(detectors.begin(), detectors.end(), [volume](const std::shared_ptr<Detector>& d) {

            return d->getName() == volume;
@@ -457,11 +463,7 @@ bool DepositionReaderModule::read_root(uint64_t event_num, 
    }



    // Read detector name

    // NOTE volume_->GetSize() is the full length, we might want to cut only part of the name

    // NOTE the string is a C string ending with \0, so we have to remove the last character

    auto full_length = volume_->GetSize() - 1;

    auto length = (volume_chars_ != 0 ? std::min(volume_chars_, full_length) : full_length);

    volume = std::string(static_cast<char*>(volume_->GetAddress()), length);

    volume = std::string(static_cast<char*>(volume_->GetAddress()));



    // Read other information, interpret in framework units:

    position = ROOT::Math::XYZPoint(
@@ -549,12 +551,6 @@ bool DepositionReaderModule::read_csv(uint64_t event_num, 
        std::istringstream(tmp) >> parent_id;

    }



    // Select the detector name from this:

    if(volume_chars_ != 0) {

        volume = volume.substr(0, std::min(volume_chars_, volume.size()));

        LOG(TRACE) << "Truncated detector name: " << volume;

    }



    // Calculate the charge deposit at a global position and convert the proper units

    position =

        ROOT::Math::XYZPoint(Units::get(px, unit_length_), Units::get(py, unit_length_), Units::get(pz, unit_length_));