Commit 85efd796 authored by Paul Schütze's avatar Paul Schütze
Browse files

Merge branch 'coverity' into 'master' 

Fix Some Issues Reported by Coverity

See merge request allpix-squared/allpix-squared!823
parents 5db880a1 96d59a38

.gitlab-ci.yml

+0 −1
Original line number Diff line number Diff line
@@ -202,7 +202,6 @@ fmt:codespell: 
fmt:coverity:

    extends: .format

    only:

        - coverity

        - schedules

    variables:

        SCHEDULE_TAG: "coverity"

src/modules/DatabaseWriter/DatabaseWriterModule.cpp

+0 −3
Original line number Diff line number Diff line
@@ -41,9 +41,6 @@ DatabaseWriterModule::DatabaseWriterModule(Configuration& config, Messenger* mes 
    config_.setDefault("require_sequence", false);



    config_.setDefault("run_id", "none");

}



void DatabaseWriterModule::initialize() {



    // retrieving configuration parameters

    host_ = config_.get<std::string>("host");

src/modules/DatabaseWriter/DatabaseWriterModule.hpp

+0 −5
Original line number Diff line number Diff line
@@ -46,11 +46,6 @@ namespace allpix { 
         */

        bool filter(const std::shared_ptr<BaseMessage>& message, const std::string& name) const;



        /**

         * @brief Parse configuration oarameters

         */

        void initialize() override;



        /**

         * @brief Initialize per-thread database connections

         */

src/modules/GenericPropagation/GenericPropagationModule.cpp

+4 −4
Original line number Diff line number Diff line
@@ -398,9 +398,9 @@ void GenericPropagationModule::run(Event* event) { 
    total_time_picoseconds_ += static_cast<long unsigned int>(total_time * 1e3);



    if(output_plots_) {

        auto total_charges = propagated_charges_count + recombined_charges_count + trapped_charges_count;

        recombine_histo_->Fill(static_cast<double>(recombined_charges_count) / total_charges);

        trapped_histo_->Fill(static_cast<double>(trapped_charges_count) / total_charges);

        auto total = (propagated_charges_count + recombined_charges_count + trapped_charges_count);

        recombine_histo_->Fill(static_cast<double>(recombined_charges_count) / (total == 0 ? 1 : total));

        trapped_histo_->Fill(static_cast<double>(trapped_charges_count) / (total == 0 ? 1 : total));

    }



    // Create a new message with propagated charges
@@ -435,7 +435,7 @@ GenericPropagationModule::propagate(const ROOT::Math::XYZPoint& pos, 


        // Compute the independent diffusion in three

        allpix::normal_distribution<double> gauss_distribution(0, diffusion_std_dev);

        Eigen::Vector3d diffusion;

        Eigen::Vector3d diffusion{};

        for(int i = 0; i < 3; ++i) {

            diffusion[i] = gauss_distribution(random_generator);

        }

src/modules/TransientPropagation/TransientPropagationModule.cpp

+1 −1
Original line number Diff line number Diff line
@@ -376,7 +376,7 @@ TransientPropagationModule::propagate(Event* event, 


        // Compute the independent diffusion in three

        allpix::normal_distribution<double> gauss_distribution(0, diffusion_std_dev);

        Eigen::Vector3d diffusion;

        Eigen::Vector3d diffusion{};

        for(int i = 0; i < 3; ++i) {

            diffusion[i] = gauss_distribution(event->getRandomEngine());

        }