Commit 6bcbd26d authored by Simon Spannagel's avatar Simon Spannagel
Browse files

Sprinkle sime well-motivated NOLINTs 

(cherry picked from commit 331e2339)
parent c0e482c5

src/core/geometry/Detector.cpp

+1 −1
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ Detector::Detector(std::string name, 
                   ROOT::Math::XYZPoint position,

                   const ROOT::Math::Rotation3D& orientation)

    : Detector(std::move(name), std::move(position), orientation) {

    model_ = std::move(model);

    model_ = std::move(model); // NOLINT

    // Check if valid model is supplied

    if(model_ == nullptr) {

        throw InvalidModuleActionException("Detector model cannot be a null pointer");

src/core/utils/text.tpp

+1 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ namespace allpix { 
            prev = pos + 1;

        }

        if(prev < str.length()) {

            elems.push_back(from_string<T>(str.substr(prev, std::string::npos)));

            elems.push_back(from_string<T>(str.substr(prev, std::string::npos))); // NOLINT

        }



        return elems;

src/modules/DatabaseWriter/DatabaseWriterModule.cpp

+5 −5
Original line number Diff line number Diff line
@@ -257,8 +257,8 @@ void DatabaseWriterModule::run(Event* event) { 
                                                                  run_nr_,

                                                                  event_nr,

                                                                  detectorName,

                                                                  reinterpret_cast<uintptr_t>(&object),

                                                                  reinterpret_cast<uintptr_t>(track.getParent()),

                                                                  reinterpret_cast<uintptr_t>(&object),           // NOLINT

                                                                  reinterpret_cast<uintptr_t>(track.getParent()), // NOLINT

                                                                  track.getParticleID(),

                                                                  track.getCreationProcessName(),

                                                                  track.getOriginatingVolumeName(),
@@ -298,9 +298,9 @@ void DatabaseWriterModule::run(Event* event) { 
                                                              event_nr,

                                                              mctrack_nr,

                                                              detectorName,

                                                              reinterpret_cast<uintptr_t>(&object),

                                                              reinterpret_cast<uintptr_t>(particle.getParent()),

                                                              reinterpret_cast<uintptr_t>(particle.getTrack()),

                                                              reinterpret_cast<uintptr_t>(&object),              // NOLINT

                                                              reinterpret_cast<uintptr_t>(particle.getParent()), // NOLINT

                                                              reinterpret_cast<uintptr_t>(particle.getTrack()),  // NOLINT

                                                              particle.getParticleID(),

                                                              particle.getLocalStartPoint().X(),

                                                              particle.getLocalStartPoint().Y(),

src/modules/DepositionReader/DepositionReaderModule.cpp

+1 −1
Original line number Diff line number Diff line
@@ -502,7 +502,7 @@ bool DepositionReaderModule::read_csv(uint64_t event_num, 
                                      int& parent_id) {



    std::string line, tmp;

    do {

    do { // NOLINT

        // Read input file line-by-line and trim whitespaces at beginning and end:

        std::getline(*input_file_, line);

        line = allpix::trim(line);

src/modules/DetectorHistogrammer/Cluster.cpp

+2 −2
Original line number Diff line number Diff line
@@ -25,9 +25,9 @@ Cluster::Cluster(const PixelHit* seed_pixel_hit) : seed_pixel_hit_(seed_pixel_hi 
    cluster_charge_ = seed_pixel_hit->getSignal();



    minX_ = seed_pixel_hit->getPixel().getIndex().x();

    maxX_ = minX_;

    maxX_ = minX_; // NOLINT

    minY_ = seed_pixel_hit->getPixel().getIndex().y();

    maxY_ = minY_;

    maxY_ = minY_; // NOLINT



    for(const auto* mc_particle : seed_pixel_hit->getMCParticles()) {

        mc_particles_.insert(mc_particle);