Commit 575425d4 authored by Simon Spannagel's avatar Simon Spannagel
Browse files

Last round of linting (hopefully)

parent 37460570

.clang-tidy

+1 −1
Original line number Diff line number Diff line
@@ -6,7 +6,7 @@ Checks : '-*, 
          mpi-*,

          performance-*,

          google-*,-google-readability-todo,-google-build-using-namespace,-google-readability-namespace-comments,-google-runtime-references,-google-runtime-int,-google-readability-casting,

          readability-*,-readability-named-parameter,-readability-inconsistent-declaration-parameter-name,-readability-avoid-const-params-in-decls,-readability-simplify-boolean-expr,-readability-redundant-declaration,-readability-else-after-return,-readability-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-const-return-type,-readability-convert-member-functions-to-static,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-use-anyofallof,

          readability-*,-readability-named-parameter,-readability-inconsistent-declaration-parameter-name,-readability-avoid-const-params-in-decls,-readability-simplify-boolean-expr,-readability-redundant-declaration,-readability-else-after-return,-readability-magic-numbers,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-const-return-type,-readability-convert-member-functions-to-static,-readability-function-cognitive-complexity,-readability-identifier-length,-readability-use-anyofallof,-readability-container-contains,

          llvm-*,-llvm-include-order,-llvm-header-guard,-llvm-namespace-comment,-llvm-qualified-auto,-llvm-else-after-return,

          modernize-*,-modernize-raw-string-literal,-modernize-use-nodiscard,-modernize-use-trailing-return-type,-modernize-avoid-bind,-modernize-macro-to-enum,

          cppcoreguidelines-*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-special-member-functions,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-owning-memory,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-macro-usage,-cppcoreguidelines-non-private-member-variables-in-classes,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-virtual-class-destructor,-cppcoreguidelines-avoid-const-or-ref-data-members,

src/core/config/ConfigReader.cpp

+1 −3
Original line number Diff line number Diff line
@@ -235,6 +235,4 @@ std::vector<Configuration> ConfigReader::getConfigurations(std::string name) con 
    return result;

}



std::vector<Configuration> ConfigReader::getConfigurations() const {

    return std::vector<Configuration>(conf_array_.begin(), conf_array_.end());

}
 
std::vector<Configuration> ConfigReader::getConfigurations() const { return {conf_array_.begin(), conf_array_.end()}; }

src/core/geometry/DetectorModel.cpp

+1 −2
Original line number Diff line number Diff line
@@ -294,8 +294,7 @@ ROOT::Math::XYZVector DetectorModel::getSize() const { 
                                                                     0);



        // Extend size unless it's already large enough to cover shifted bump bond grid:

        return ROOT::Math::XYZVector(

            std::max(size.x(), bump_grid.x()), std::max(size.y(), bump_grid.y()), std::max(size.z(), bump_grid.z()));

        return {std::max(size.x(), bump_grid.x()), std::max(size.y(), bump_grid.y()), std::max(size.z(), bump_grid.z())};

    }

    return size;

}

src/core/geometry/GeometryManager.cpp

+1 −1
Original line number Diff line number Diff line
@@ -504,7 +504,7 @@ std::pair<XYZPoint, Rotation3D> GeometryManager::calculate_orientation(const Con 
    } else {

        throw InvalidValueError(config, "orientation_mode", "orientation_mode should be either 'zyx', xyz' or 'zxz'");

    }

    return std::pair<XYZPoint, Rotation3D>(position, orientation);

    return {position, orientation};

}



bool GeometryManager::hasMagneticField() const { return (magnetic_field_type_ != MagneticFieldType::NONE); }

src/core/module/ThreadPool.cpp

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ ThreadPool::ThreadPool(unsigned int num_threads, 
                       const std::function<void()>& worker_init_function,

                       const std::function<void()>& worker_finalize_function)

    : ThreadPool(num_threads, max_queue_size, 0, worker_init_function, worker_finalize_function) {

    with_buffered_ = false;

    with_buffered_ = false; // NOLINT

}



ThreadPool::ThreadPool(unsigned int num_threads,