Commit 1ba78a3e authored by Simon Spannagel's avatar Simon Spannagel
Browse files

Merge branch 'fix_signed_cast' into 'master' 

Prevent casting negative charge to unsigned int

See merge request allpix-squared/allpix-squared!953
parents 16758ed4 a2b30ed7

src/modules/DepositionGeant4/SensitiveDetectorActionG4.cpp

+1 −1
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ G4bool SensitiveDetectorActionG4::ProcessHits(G4Step* step, G4TouchableHistory*) 
    // excitations via the Fano factor. We assume Gaussian statistics here.

    auto mean_charge = edep / charge_creation_energy_;

    allpix::normal_distribution<double> charge_fluctuation(mean_charge, std::sqrt(mean_charge * fano_factor_));

    auto charge = static_cast<unsigned int>(charge_fluctuation(random_generator_));

    auto charge = static_cast<unsigned int>(std::max(charge_fluctuation(random_generator_), 0.));



    const auto* userTrackInfo = dynamic_cast<TrackInfoG4*>(track->GetUserInformation());

    if(userTrackInfo == nullptr) {