From c5d07e2c2825129a37e8d3cac4c19ff3692c11f6 Mon Sep 17 00:00:00 2001
From: Arseny Kapoulkine <arseny.kapoulkine@gmail.com>
Date: Sun, 12 Apr 2015 02:34:48 -0700
Subject: [PATCH] tests: Add a test that verifies absence of file leaks
If an out of memory error happens in load_file there's a danger of leaking
the FILE object. Since there is a limited supply of the objects we can easily
test that the leak does not happen.
---
tests/test_document.cpp | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/tests/test_document.cpp b/tests/test_document.cpp
index d81458ab..1545e19b 100644
--- a/tests/test_document.cpp
+++ b/tests/test_document.cpp
@@ -302,11 +302,33 @@ TEST(document_load_file_error)
pugi::xml_document doc;
CHECK(doc.load_file("filedoesnotexist").status == status_file_not_found);
+}
+TEST(document_load_file_out_of_memory)
+{
test_runner::_memory_fail_threshold = 1;
+
+ pugi::xml_document doc;
CHECK_ALLOC_FAIL(CHECK(doc.load_file("tests/data/small.xml").status == status_out_of_memory));
}
+TEST(document_load_file_out_of_memory_file_leak)
+{
+ test_runner::_memory_fail_threshold = 1;
+
+ pugi::xml_document doc;
+
+ for (int i = 0; i < 256; ++i)
+ {
+ CHECK_ALLOC_FAIL(CHECK(doc.load_file("tests/data/small.xml").status == status_out_of_memory));
+ }
+
+ test_runner::_memory_fail_threshold = 0;
+
+ CHECK(doc.load_file("tests/data/small.xml"));
+ CHECK_NODE(doc, STR("<node />"));
+}
+
TEST(document_load_file_error_previous)
{
pugi::xml_document doc;
--
GitLab