The unnecessary casting ops between integer and index types cause the Affine for validation failed. This only occurs when the constant values are created inside another affine scope.

Fixing the const index value builder to create the index const directly and the loop statement handler in the range-based case to create index type.

Added the test case (https://github.com/ORNL-QCI/qcor/issues/240

)

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

When porting  QCOR_EXPECT_TRUE to region-based construct, I realized there is another directive which hasn't been handled: early return.

Adding a test for early returns.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Rewrite using an if block.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Also, rename the loop control tracking var name to reflect that it supports all loop types.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

All the loop constructs have now been converted to Affine/SCF

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

- Simplify the structure: the loop handler detect if it contains break/continue to set up the structure (conditional body). i.e., no need to move code after the body is constructed.

- Properly handle loop continuation directive, i.e., a true break point and ready for continue implementation.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

- Moving control directive handling to a separate cpp file for maintainability.

- Use outlining technique to wrap breakable loop body in a scf::if block

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Added a helper to check the ANTLR4 node type rather than text (not reliable)

Clean-up for merging before supporting MLIR Regions-based break/continue.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

- Refactor the `evaluate_constant_integer_expression` util to allow for a safe (no throwing) check.

- Loop handler to check whether the loop bounds could be const-eval.

-> Fixed https://github.com/ORNL-QCI/qcor/issues/180

: This fix will bypass the global memref loading -> make the affine loop const at MLIR level -> enable unrolling at MLIR level.

- Add simple tests.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Affine for loops cannot be mixed with other manual branching structures yet. Need to debug further; disable for now.

The affine for validation failure seems to be related to IndexType, not memref.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Affine loop doesn't support negative step, hence need to transform the loop by ourselves.

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

- Type mismatches since affine loop var is always of index type.

- I don't know how to make affine loop to work with memref bounds yet; hence don't try to create an affine loop in that case

- Run inliner both before and after loop unroll to make sure CallOps are inlined

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Our Affine for loop cannot handle break inside its body yet...

Fallback to the manual construction

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Making sure that we use the IndexType (not integer type) for MemRef

Signed-off-by: Thien Nguyen <nguyentm@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

bug fixes and implementation to support qpe.qasm example using ctrl and pow gate modifiers, plus a iqft subroutine.

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

update for loop to use declared variables as loop indices, minor bug fixes, add tests for control directives and superposition demo, add deuteron ftqc example

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

update all variables to be memref<TYPE> on shape of rank 0. fixed how const global vars are handled, they are now global memrefs

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

started on updated parser/visitor based on improved qasm3.g4. added the ability to JIT execute the lowered qasm3 code for the tests

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>

Signed-off-by: Alex McCaskey <mccaskeyaj@ornl.gov>