Inconsistency between the documentation and implemetation for ON/OFF option
Created by: keichi
I found a minor inconsistency between the documentation and implementation.
The documentation for the BPFile engine says string ON
or OFF
should be used to enable/disable Profile or CollectiveMetadata.
However, the implementation does not accept uppercase ON
/OFF
, but only lowercase on
/off
or camelcase On
/Off
.
For example, if I put the following line in my XML,
<parameter key="CollectiveMetadata" value="OFF"/>
I see the following error message:
ERROR: IO SetParameters profile invalid value, valid: CollectiveMetadata On or Off in call to Open
The corresponding method in the source code is https://github.com/ornladios/ADIOS2/blob/ab1a2e45dda32235158e67091ee37b40cb27ad84/source/adios2/toolkit/format/bp3/BP3Base.cpp#L310