Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • A ADIOS2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 97
    • Issues 97
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Podhorszki, Norbert
  • ADIOS2
  • Issues
  • #1602
Closed
Open
Issue created Jul 06, 2019 by Podhorszki, Norbert@pnbOwner

CI: Add more compiler warnings

Created by: germasch

@chuckatkins: Learning from the last minute MSVC troubles before the release, which were (in part) caused by variable length arrays on the stack, which is not a standard C++ feature, how about adding -pedantic-errors to the CI when the compiler is gcc/clang? This will catch this problem, and potentially avoid other non-standard use of C++.

It actually turns out that you'd have to add -Wno-gnu-zero-variadic-macro-arguments since gtest relies on that, and no fix appears to exist (yet): https://github.com/google/googletest/issues/1419

A more limited approach would be to just avoid the use of variable length arrays with -Werror=vla.

Assignee
Assign to
Time tracking