Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • A ADIOS2
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 97
    • Issues 97
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Podhorszki, Norbert
  • ADIOS2
  • Issues
  • #1208

Closed
Open
Created Feb 19, 2019 by Podhorszki, Norbert@pnbOwner

bzip2 compression only for certain types?

Created by: germasch

DataManSerializer::IsCompressionAvailable() contains this code, which may just have been copy&pasted from other compression methods.

else if (method == "bzip2")
    {
      if (type == helper::GetType<int32_t>() || type == helper::GetType<int64_t>() ||
	  type == helper::GetType<float>() || type == helper::GetType<double>())
        {
            return true;
        }
    }

The other compression methods are lossy and constrain their types, but for all I'm aware, bzip2 is lossless, so I don't really see why it would need to be restricted to certain types?

This is certainly not a big issue, just something I saw along the way, so I thought I'd note it.

Assignee
Assign to
Time tracking