1. 03 Mar, 2020 7 commits
    • Atkins, Charles Vernon's avatar
      Merge pull request #2011 from bradking/comm-mpi-ownership · 65c4a1a4
      Atkins, Charles Vernon authored
      helper: Do not always duplicate MPI_Comm on Comm construction
      65c4a1a4
    • Brad King's avatar
      helper: Do not always duplicate MPI_Comm on Comm construction · 00d5f840
      Brad King authored
      Through a series of commits:
      
      * f7fec28f (core: Refactor ADIOS factory to use Comm encapsulation, 2019-06-21, v2.5.0~66^2~35)
      * 29177b01 (engine: Construct with Comm encapsulation, 2019-06-18, v2.5.0~66^2~31)
      * 33715618 (helper: Factor out MPI-specific Comm interfaces, 2019-09-12)
      * 89891238 (core: Replace MPI with Comm in ADIOS, IO, and Stream interfaces, 2019-10-07)
      
      we converted the core::ADIOS constructor from taking a `MPI_Comm`
      and calling `MPI_Comm_dup` internally to taking an instance of
      `helper::Comm` by value, typically moved from an instance created
      by `helper::CommFromMPI`.  Therefore `helper::CommFromMPI` calls
      `MPI_Comm_dup` to preserve the existing semantics.
      
      However, two commits introduced uses of `helper::CommFromMPI` in places
      that did not previously use `MPI_Comm_dup`:
      
      * 554a756f (utils: Port adios_reorganize to Comm encapsulation, 2019-09-19)
      * 1ec1ec43 (sst: Re-implement SMPI_ interfaces as C wrappers of Comm encapsulation, 2020-02-11)
      
      The calls updated by those commits are intend to create a `helper::Comm`
      that uses `MPI_COMM_WORLD` without duplicating it.
      
      In order to distinguish the cases that duplicate from those that do not,
      replace `helper::CommFromMPI` with two variants:
      
      * `helper::CommDupMPI` to duplicate the given `MPI_Comm`
      * `helper::CommWithMPI` to take ownership of the given `MPI_Comm`
      
      Update all the call sites to use the variant with appropriate semantics.
      
      Fixes: #2008
      00d5f840
    • Atkins, Charles Vernon's avatar
      Merge pull request #2002 from khuck/fixing_2001 · dab81f1d
      Atkins, Charles Vernon authored
      helper: Avoid freeing Comm-held MPI_Comm more than once
      dab81f1d
    • Atkins, Charles Vernon's avatar
      Merge pull request #2004 from NAThompson/zfp_parameter_fix · 801cbe77
      Atkins, Charles Vernon authored
      Fix ZFP error message.
      801cbe77
    • pnorbert's avatar
      Merge pull request #2005 from NAThompson/ignore_tlc · 38b36d51
      pnorbert authored
      Ignore files generated by readthedocs.
      38b36d51
    • Nick's avatar
      Take all keys to lower case. · 78c73b95
      Nick authored
      78c73b95
    • Huck, Kevin's avatar
      helper: Avoid freeing Comm-held MPI_Comm more than once · 7b2ee235
      Huck, Kevin authored
      The `Comm::Free` method may be called more than once by applications.
      Although some MPI vendors document that `MPI_Comm_free` sets the
      given handle to `MPI_COMM_NULL`, this does not always happen in
      practice.  Set the handle to `MPI_COMM_NULL` explicitly to avoid
      calling `MPI_Comm_free` more than once for the same handle.
      
      Without this, when compiled with PGI and executed with TAU profiling,
      a double-free occurs and causes memory to be corrupted.
      7b2ee235
  2. 02 Mar, 2020 19 commits
  3. 01 Mar, 2020 4 commits
  4. 28 Feb, 2020 6 commits
  5. 27 Feb, 2020 4 commits