From 7dd9d728c5652ad49da02bc38e32f64b8042fe03 Mon Sep 17 00:00:00 2001
From: Chuck Atkins <chuck.atkins@kitware.com>
Date: Wed, 26 Apr 2017 11:11:43 -0400
Subject: [PATCH] Add asserts to disabled tests.
This will ensure that even if they are run they will fail
---
.../engine/adios1/TestADIOS1WriteRead.cpp | 12 ++++++------
testing/adios2/engine/bp/TestBPWriteRead.cpp | 6 +++---
.../adios2/engine/hdf5/TestHDF5WriteRead.cpp | 18 ++++++++++++------
3 files changed, 21 insertions(+), 15 deletions(-)
diff --git a/testing/adios2/engine/adios1/TestADIOS1WriteRead.cpp b/testing/adios2/engine/adios1/TestADIOS1WriteRead.cpp
index ce2076a99..fc27d5323 100644
--- a/testing/adios2/engine/adios1/TestADIOS1WriteRead.cpp
+++ b/testing/adios2/engine/adios1/TestADIOS1WriteRead.cpp
@@ -236,7 +236,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS2ADIOS1WriteADIOS2ADIOS1Read1D8)
{
std::string fname = "ADIOS2ADIOS1WriteADIOS2ADIOS1Read1D8.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native ADIOS1 write, ADIOS2 read
@@ -244,7 +244,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS1WriteADIOS2ADIOS1Read1D8)
{
std::string fname = "ADIOS1WriteADIOS2ADIOS1Read1D8.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -473,7 +473,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS2ADIOS1WriteADIOS2ADIOS1Read2D2x4)
{
std::string fname = "ADIOS2ADIOS1WriteADIOS2ADIOS1Read2D2x4Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native ADIOS1 write, ADIOS2 read
@@ -481,7 +481,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS1WriteADIOS2ADIOS1Read2D2x4)
{
std::string fname = "ADIOS1WriteADIOS2ADIOS1Read2D2x4Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -710,7 +710,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS2ADIOS1WriteADIOS2ADIOS1Read2D4x2)
{
std::string fname = "ADIOS2ADIOS1WriteADIOS2ADIOS1Read2D4x2Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native ADIOS1 write, ADIOS2 read
@@ -718,7 +718,7 @@ TEST_F(ADIOS1WriteReadTest, DISABLED_ADIOS1WriteADIOS2ADIOS1Read2D4x2)
{
std::string fname = "ADIOS1WriteADIOS2ADIOS1Read2D4x2Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
diff --git a/testing/adios2/engine/bp/TestBPWriteRead.cpp b/testing/adios2/engine/bp/TestBPWriteRead.cpp
index 2096a119e..2ca330c48 100644
--- a/testing/adios2/engine/bp/TestBPWriteRead.cpp
+++ b/testing/adios2/engine/bp/TestBPWriteRead.cpp
@@ -230,7 +230,7 @@ TEST_F(BPWriteReadTest, DISABLED_ADIOS2BPWriteADIOS2BPRead1D8)
{
std::string fname = "ADIOS2BPWriteADIOS2BPRead1D8.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -454,7 +454,7 @@ TEST_F(BPWriteReadTest, DISABLED_ADIOS2BPWriteADIOS2BPRead2D2x4)
{
std::string fname = "ADIOS2BPWriteADIOS2BPRead2D2x4Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -678,7 +678,7 @@ TEST_F(BPWriteReadTest, DISABLED_ADIOS2BPWriteADIOS2BPRead2D4x2)
{
std::string fname = "ADIOS2BPWriteADIOS2BPRead2D4x2Test.bp";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
diff --git a/testing/adios2/engine/hdf5/TestHDF5WriteRead.cpp b/testing/adios2/engine/hdf5/TestHDF5WriteRead.cpp
index 3693d2271..bac7570fb 100644
--- a/testing/adios2/engine/hdf5/TestHDF5WriteRead.cpp
+++ b/testing/adios2/engine/hdf5/TestHDF5WriteRead.cpp
@@ -98,6 +98,8 @@ TEST_F(HDF5WriteReadTest, ADIOS2HDF5WriteHDF5Read1D8)
// Read test data using HDF5
{
+ ASSERT_TRUE(false)
+ << "Native HDF5 read validation is not yet implemented";
}
}
@@ -106,7 +108,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_ADIOS2HDF5WriteADIOS2HDF5Read1D8)
{
std::string fname = "ADIOS2HDF5WriteADIOS2HDF5Read1D8.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native HDF5 write, ADIOS2 read
@@ -114,7 +116,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_HDF5WriteADIOS2HDF5Read1D8)
{
std::string fname = "HDF5WriteADIOS2HDF5Read1D8.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -196,6 +198,8 @@ TEST_F(HDF5WriteReadTest, ADIOS2HDF5WriteHDF5Read2D2x4)
// Read test data using HDF5
{
+ ASSERT_TRUE(false)
+ << "Native HDF5 read validation is not yet implemented";
}
}
@@ -204,7 +208,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_ADIOS2HDF5WriteADIOS2HDF5Read2D2x4)
{
std::string fname = "ADIOS2HDF5WriteADIOS2HDF5Read2D2x4Test.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native HDF5 write, ADIOS2 read
@@ -212,7 +216,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_HDF5WriteADIOS2HDF5Read2D2x4)
{
std::string fname = "HDF5WriteADIOS2HDF5Read2D2x4Test.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
@@ -294,6 +298,8 @@ TEST_F(HDF5WriteReadTest, ADIOS2HDF5WriteHDF5Read2D4x2)
// Read test data using HDF5
{
+ ASSERT_TRUE(false)
+ << "Native HDF5 read validation is not yet implemented";
}
}
@@ -302,7 +308,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_ADIOS2HDF5WriteADIOS2HDF5Read2D4x2)
{
std::string fname = "ADIOS2HDF5WriteADIOS2HDF5Read2D4x2Test.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
// Native HDF5 write, ADIOS2 read
@@ -310,7 +316,7 @@ TEST_F(HDF5WriteReadTest, DISABLED_HDF5WriteADIOS2HDF5Read2D4x2)
{
std::string fname = "HDF5WriteADIOS2HDF5Read2D4x2Test.h5";
- // Not yet implemented since read API is not ready
+ ASSERT_TRUE(false) << "ADIOS2 read API is not yet implemented";
}
//******************************************************************************
--
GitLab