From 6e3a5b2715ceaf8684520d8f362e3738d0ba61bb Mon Sep 17 00:00:00 2001
From: Chuck Atkins <chuck.atkins@kitware.com>
Date: Mon, 3 Apr 2017 14:08:18 -0400
Subject: [PATCH] Convert most reinterpret_cast to static_cast
---
source/format/BP1Writer.cpp | 13 ++++++-------
source/functions/adiosFunctions.cpp | 4 ++--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/source/format/BP1Writer.cpp b/source/format/BP1Writer.cpp
index cfe028834..6c8d5207f 100644
--- a/source/format/BP1Writer.cpp
+++ b/source/format/BP1Writer.cpp
@@ -71,7 +71,7 @@ void BP1Writer::WriteProcessGroupIndex(
// offset to pg in data in metadata which is the current absolute position
CopyToBuffer(metadataBuffer,
- reinterpret_cast<std::uint64_t *>(&heap.m_DataAbsolutePosition));
+ static_cast<uint64_t *>(&heap.m_DataAbsolutePosition));
// Back to writing metadata pg index length (length of group)
const std::uint16_t metadataPGIndexLength =
@@ -204,7 +204,7 @@ void BP1Writer::WriteDimensionsRecord(
auto lf_WriteFlaggedDim = [](std::vector<char> &buffer, const char no,
const std::size_t dimension) {
CopyToBuffer(buffer, &no);
- CopyToBuffer(buffer, reinterpret_cast<const std::uint64_t *>(&dimension));
+ CopyToBuffer(buffer, static_cast<const uint64_t *>(&dimension));
};
// BODY Starts here
@@ -225,7 +225,7 @@ void BP1Writer::WriteDimensionsRecord(
for (const auto &localDimension : localDimensions)
{
CopyToBuffer(buffer,
- reinterpret_cast<const std::uint64_t *>(&localDimension));
+ static_cast<const uint64_t *>(&localDimension));
buffer.insert(buffer.end(), skip, 0);
}
}
@@ -246,12 +246,11 @@ void BP1Writer::WriteDimensionsRecord(
{
for (unsigned int d = 0; d < localDimensions.size(); ++d)
{
- CopyToBuffer(buffer, reinterpret_cast<const std::uint64_t *>(
+ CopyToBuffer(buffer, static_cast<const uint64_t *>(
&localDimensions[d]));
- CopyToBuffer(buffer, reinterpret_cast<const std::uint64_t *>(
+ CopyToBuffer(buffer, static_cast<const uint64_t *>(
&globalDimensions[d]));
- CopyToBuffer(
- buffer, reinterpret_cast<const std::uint64_t *>(&globalOffsets[d]));
+ CopyToBuffer(buffer, static_cast<const uint64_t *>(&globalOffsets[d]));
}
}
}
diff --git a/source/functions/adiosFunctions.cpp b/source/functions/adiosFunctions.cpp
index 55d4c68f8..78393c641 100644
--- a/source/functions/adiosFunctions.cpp
+++ b/source/functions/adiosFunctions.cpp
@@ -677,8 +677,8 @@ int GrowBuffer(const std::size_t incomingDataSize, const float growthFactor,
bool IsLittleEndian() noexcept
{
- std::uint16_t hexa = 0x1234;
- return *reinterpret_cast<std::uint8_t *>(&hexa) != 0x12;
+ uint16_t hexa = 0x1234;
+ return *reinterpret_cast<uint8_t *>(&hexa) != 0x12; // NOLINT
}
} // namespace adios
--
GitLab