Unverified Commit fc302c3a authored by Rick van Schijndel's avatar Rick van Schijndel Committed by GitHub
Browse files

Merge pull request #216795 from nviets/xgboost174 

xgboost: 1.7.3 -> 1.7.4
parents 665cbdb5 69f859f8

pkgs/development/libraries/xgboost/default.nix

+14 −2
Original line number Diff line number Diff line
@@ -37,14 +37,14 @@ stdenv.mkDerivation rec { 
  #   in \

  #   rWrapper.override{ packages = [ xgb ]; }"

  pname = lib.optionalString rLibrary "r-" + pnameBase;

  version = "1.7.3";

  version = "1.7.4";



  src = fetchFromGitHub {

    owner = "dmlc";

    repo = pnameBase;

    rev = "v${version}";

    fetchSubmodules = true;

    hash = "sha256-unTss2byytG8KUQfg5s34YpRuHHDLo7D/ZickHhz1AE=";

    hash = "sha256-HGS9w4g2+Aw5foKjHK/XQvSCnFHUswhzAsQf6XkdvOI=";

  };



  nativeBuildInputs = [ cmake ]
@@ -90,6 +90,18 @@ stdenv.mkDerivation rec { 
    }

  '';



  # Disable finicky tests from dmlc core that fail in Hydra. XGboost team

  # confirmed xgboost itself does not use this part of the dmlc code.

  GTEST_FILTER =

    let

      # Upstream Issue: https://github.com/xtensor-stack/xsimd/issues/456

      filteredTests = lib.optionals stdenv.hostPlatform.isDarwin [

        "ThreadGroup.TimerThread"

        "ThreadGroup.TimerThreadSimple"

      ];

    in

    "-${builtins.concatStringsSep ":" filteredTests}";



  installPhase =

    let libname = "libxgboost${stdenv.hostPlatform.extensions.sharedLibrary}";

    in ''