Unverified Commit ed86661d authored by Kevin Cox's avatar Kevin Cox
Browse files

cross-seed: Remove broken test. 

This test has always been broken. The fix is not obvious, there was an attempt to set up mount namespaces, but this will fail if the output directory doesn't exist. In the default configuration it will fail because the directory doesn't exist until cross-seed runs the first time. This points at a real issue with the module that should be addressed. But for now let's remove the broken test, then we can add it back in working condition.

Original PR: https://github.com/NixOS/nixpkgs/pull/383409
parent cdab07ac

nixos/tests/all-tests.nix

+0 −1
Original line number Diff line number Diff line
@@ -253,7 +253,6 @@ in { 
  curl-impersonate = handleTest ./curl-impersonate.nix {};

  custom-ca = handleTest ./custom-ca.nix {};

  croc = handleTest ./croc.nix {};

  cross-seed = runTest ./cross-seed.nix;

  cyrus-imap = runTest ./cyrus-imap.nix;

  darling = handleTest ./darling.nix {};

  darling-dmg = runTest ./darling-dmg.nix;

nixos/tests/cross-seed.nix

deleted100644 → 0
+0 −43
Original line number Diff line number Diff line 
{ lib, ... }:

let

  apiKey = "twentyfourcharacterskey!";

in

{

  name = "cross-seed";

  meta.maintainers = with lib.maintainers; [ pta2002 ];



  nodes.machine =

    { pkgs, config, ... }:

    let

      cfg = config.services.cross-seed;

    in

    {

      systemd.tmpfiles.settings."0-cross-seed-test"."${cfg.settings.torrentDir}".d = {

        inherit (cfg) user group;

        mode = "700";

      };



      services.cross-seed = {

        enable = true;

        settings = {

          outputDir = "/var/lib/cross-seed/output";

          torrentDir = "/var/lib/torrents";

          torznab = [ ];

          useClientTorrents = false;

        };

        # # We create this secret in the Nix store (making it readable by everyone).

        # # DO NOT DO THIS OUTSIDE OF TESTS!!

        settingsFile = (pkgs.formats.json { }).generate "secrets.json" {

          inherit apiKey;

        };

      };

    };



  testScript = # python

    ''

      start_all()

      machine.wait_for_unit("cross-seed.service")

      machine.wait_for_open_port(2468)

      machine.succeed("curl --fail -XPOST http://localhost:2468/api/search?apiKey=${apiKey}")

    '';

}

pkgs/by-name/cr/cross-seed/package.nix

+0 −3
Original line number Diff line number Diff line
@@ -2,7 +2,6 @@ 
  lib,

  buildNpmPackage,

  fetchFromGitHub,

  nixosTests,

}:



buildNpmPackage rec {
@@ -18,8 +17,6 @@ buildNpmPackage rec { 


  npmDepsHash = "sha256-hqQi0kSPm9SKEoLu6InvRMPxbQ+CBpKVPJhhOdo2ZII=";



  passthru.tests.cross-seed = nixosTests.cross-seed;



  meta = {

    description = "Fully-automatic torrent cross-seeding with Torznab";

    homepage = "https://cross-seed.org";