Unverified Commit ed355d46 authored by Weijia Wang's avatar Weijia Wang Committed by GitHub
Browse files

bazel_8: 8.4.1 -> 8.4.2 (#450259)

parents cca043ff d4c44593
Loading
Loading
Loading
Loading
+4 −4
Original line number Diff line number Diff line
@@ -108,10 +108,10 @@ in
    bazelVendorDepsFOD = {
      outputHash =
        {
          aarch64-darwin = "sha256-D5bwW35QuLLhVE22FDyV9Nl8N7ULx71wCHbzB81+Xx0=";
          aarch64-linux = "sha256-F5X/cwtHR6sVFe1DzNDaEnGMIPR0SnXq2iIxhQeqIV8=";
          x86_64-darwin = "sha256-DXuPy68m3p6hlgEid7tpY8fGgvJWQTXth6h2kMSNFCc=";
          x86_64-linux = "sha256-oNLDccQ/XPg1Nl/9V14NdgiQsRoTvpaA6hyynMb414A=";
          aarch64-darwin = "sha256-0QtaPtcBljyhiJGwA8ctSpi+UQp/9q/ZoHUHORizmlY=";
          aarch64-linux = "sha256-zpiwQ8OB8KhY+kxSXlSOd/zmoH1VGYDGgojf4Or04pQ=";
          x86_64-darwin = "sha256-+tCDSuYkon1DEARwWTYABJbmysSNAK9vy0tCm8YsGjQ=";
          x86_64-linux = "sha256-wCWSRc20Yr/hdXn8szbhLAX7Oy3G5keyHTTdO0msnks=";
        }
        .${stdenv.hostPlatform.system};
      outputHashAlgo = "sha256";
+2 −4
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@
  cctools,
  # Allow to independently override the jdks used to build and run respectively
  jdk_headless,
  version ? "8.4.1",
  version ? "8.4.2",
}:

let
@@ -45,7 +45,7 @@ let

  src = fetchzip {
    url = "https://github.com/bazelbuild/bazel/releases/download/${version}/bazel-${version}-dist.zip";
    hash = "sha256-DqJqW7C1QODOS+vJrs/+ixsP3coZh80VdpPM4g0vxFI=";
    hash = "sha256-5oNYKHPaDkpunl6oC104Rh1wAEMWfLfvCFdGHlXZn4o=";
    stripRoot = false;
  };

@@ -144,9 +144,7 @@ stdenv.mkDerivation rec {
    # Nixpkgs toolcahins do not support that (yet?) and get confused.
    # Also add an explicit /usr/bin prefix that will be patched below.
    (replaceVars ./patches/xcode.patch {
      usrBinEnv = "${coreutils}/bin/env";
      clangDarwin = "${stdenv.cc}/bin/clang";
      codesign = "${darwin.sigtool}/bin/codesign";
    })

    # Revert preference for apple_support over rules_cc toolchain for now
+2 −2
Original line number Diff line number Diff line
@@ -8,11 +8,11 @@ index b3dde1c838..a54bf8141d 100644
 
-# Depend on apple_support first and then rules_cc so that the Xcode toolchain
-# from apple_support wins over the generic Unix toolchain from rules_cc.
-bazel_dep(name = "apple_support", version = "1.18.1")
-bazel_dep(name = "apple_support", version = "1.23.1")
+# Not Depend on apple_support first and then rules_cc so that the Xcode toolchain
+# from apple_support not wins over the generic Unix toolchain from rules_cc.
 bazel_dep(name = "rules_cc", version = "0.1.1")
+bazel_dep(name = "apple_support", version = "1.18.1")
+bazel_dep(name = "apple_support", version = "1.23.1")
 
 # repo_name needs to be used, until WORKSPACE mode is to be supported in bazel_tools
 bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf")
+3 −7
Original line number Diff line number Diff line
@@ -12,20 +12,16 @@ index 1bad14cba7..d312fe08bb 100755
   cp tools/osx/xcode_locator_stub.sh ${ARCHIVE_DIR}/xcode-locator
 fi
diff --git a/tools/osx/BUILD b/tools/osx/BUILD
index 0358fb0ffe..1e6eae1f33 100644
index 5b99589ad4..3d3269772b 100644
--- a/tools/osx/BUILD
+++ b/tools/osx/BUILD
@@ -27,9 +27,9 @@ exports_files([
@@ -27,7 +27,7 @@ exports_files([
 ])
 
 DARWIN_XCODE_LOCATOR_COMPILE_COMMAND = """
-  /usr/bin/xcrun --sdk macosx clang -mmacosx-version-min=10.13 -fobjc-arc -framework CoreServices \
-      -framework Foundation -arch arm64 -arch x86_64 -Wl,-no_adhoc_codesign -Wl,-no_uuid -o $@ $< && \
-  env -i codesign --identifier $@ --force --sign - $@
+  @clangDarwin@ -mmacosx-version-min=10.13 -fobjc-arc -framework CoreServices \
+      -framework Foundation -Wl,-no_adhoc_codesign -Wl,-no_uuid -o $@ $< && \
+  @usrBinEnv@ @codesign@ --identifier $@ --force --sign - $@
       -framework Foundation -arch arm64 -arch x86_64 -o $@ $<
 """
 
 genrule(