Unverified Commit e96455db authored by Luna Nova's avatar Luna Nova
Browse files

rocmPackages.rocblas: move tests and benchmarks to passthru.tests 

Test and bench data bloated rocblas' closure size by around 1.1G
parent eb913725

pkgs/development/rocm-modules/6/default.nix

+1 −4
Original line number Diff line number Diff line
@@ -134,10 +134,7 @@ let 
          ;

      };



      rocblas = self.callPackage ./rocblas {

        buildTests = true;

        buildBenchmarks = true;

      };

      rocblas = self.callPackage ./rocblas { };



      rocsolver = self.callPackage ./rocsolver { };

pkgs/development/rocm-modules/6/rocblas/default.nix

+13 −8
Original line number Diff line number Diff line
@@ -25,8 +25,8 @@ 
  rocm-smi,

  pkg-config,

  buildTensile ? true,

  buildTests ? true,

  buildBenchmarks ? true,

  buildTests ? false,

  buildBenchmarks ? false,

  tensileSepArch ? true,

  tensileLazyLib ? true,

  withHipBlasLt ? true,
@@ -130,8 +130,6 @@ stdenv.mkDerivation (finalAttrs: { 
    (lib.cmakeBool "Tensile_LAZY_LIBRARY_LOADING" tensileLazyLib)

  ];



  passthru.amdgpu_targets = gpuTargets';



  patches = [

    (fetchpatch {

      name = "Extend-rocBLAS-HIP-ISA-compatibility.patch";
@@ -150,11 +148,18 @@ stdenv.mkDerivation (finalAttrs: { 
      --replace-fail '0.10' '1.0'

  '';



  passthru.updateScript = rocmUpdateScript {

  passthru = {

    amdgpu_targets = gpuTargets';

    tests.rocblas-tests = finalAttrs.finalPackage.override {

      buildBenchmarks = true;

      buildTests = true;

    };

    updateScript = rocmUpdateScript {

      name = finalAttrs.pname;

      inherit (finalAttrs.src) owner;

      inherit (finalAttrs.src) repo;

    };

  };



  enableParallelBuilding = true;

  requiredSystemFeatures = [ "big-parallel" ];