Merge pull request #257047 from minijackson/netbox-3.6.2

  - A list of all extras (and the extras enabled by default) can be found at the [option's reference for `services.matrix-synapse.extras`](#opt-services.matrix-synapse.extras).

  - In some cases (e.g. for running synapse workers) it was necessary to re-use the `PYTHONPATH` of `matrix-synapse.service`'s environment to have all plugins available. This isn't necessary anymore, instead `config.services.matrix-synapse.package` can be used as it points to the wrapper with properly configured `extras` and also all plugins defined via [`services.matrix-synapse.plugins`](#opt-services.matrix-synapse.plugins) available. This is also the reason for why the option is read-only now, it's supposed to be set by the module only.

- `netbox` was updated to 3.6. NixOS' `services.netbox.package` still defaults to 3.5 if `stateVersion` is earlier than 23.11. Please review upstream's breaking changes [for 3.6.0](https://github.com/netbox-community/netbox/releases/tag/v3.6.0) and upgrade NetBox by changing `services.netbox.package`. Database migrations will be run automatically.

- `etcd` has been updated to 3.5, you will want to read the [3.3 to 3.4](https://etcd.io/docs/v3.5/upgrades/upgrade_3_4/) and [3.4 to 3.5](https://etcd.io/docs/v3.5/upgrades/upgrade_3_5/) upgrade guides

- `gitlab` installations created or updated between versions \[15.11.0, 15.11.2] have an incorrect database schema. This will become a problem when upgrading to `gitlab` >=16.2.0. A workaround for affected users can be found in the [GitLab docs](https://docs.gitlab.com/ee/update/versions/gitlab_16_changes.html#undefined-column-error-upgrading-to-162-or-later).

    package = lib.mkOption {

      type = lib.types.package;

      default = if lib.versionAtLeast config.system.stateVersion "23.05" then pkgs.netbox else pkgs.netbox_3_3;

      default =

        if lib.versionAtLeast config.system.stateVersion "23.11"

        then pkgs.netbox_3_6

        else if lib.versionAtLeast config.system.stateVersion "23.05"

        then pkgs.netbox_3_5

        else pkgs.netbox_3_3;

      defaultText = lib.literalExpression ''

        if versionAtLeast config.system.stateVersion "23.05" then pkgs.netbox else pkgs.netbox_3_3;

        if lib.versionAtLeast config.system.stateVersion "23.11"

        then pkgs.netbox_3_6

        else if lib.versionAtLeast config.system.stateVersion "23.05"

        then pkgs.netbox_3_5

        else pkgs.netbox_3_3;

      '';

      description = lib.mdDoc ''

        NetBox package to use.

  netdata = handleTest ./netdata.nix {};

  networking.networkd = handleTest ./networking.nix { networkd = true; };

  networking.scripted = handleTest ./networking.nix { networkd = false; };

  netbox = handleTest ./web-apps/netbox.nix { inherit (pkgs) netbox; };

  netbox_3_3 = handleTest ./web-apps/netbox.nix { netbox = pkgs.netbox_3_3; };

  netbox_3_5 = handleTest ./web-apps/netbox.nix { netbox = pkgs.netbox_3_5; };

  netbox_3_6 = handleTest ./web-apps/netbox.nix { netbox = pkgs.netbox_3_6; };

  netbox-upgrade = handleTest ./web-apps/netbox-upgrade.nix {};

  # TODO: put in networking.nix after the test becomes more complete

  networkingProxy = handleTest ./networking-proxy.nix {};

import ../make-test-python.nix ({ lib, pkgs, ... }: let

  oldNetbox = pkgs.netbox_3_3;

  oldNetbox = pkgs.netbox_3_5;

  newNetbox = pkgs.netbox_3_6;

in {

  name = "netbox-upgrade";

  meta = with lib.maintainers; {

    maintainers = [ minijackson ];

    maintainers = [ minijackson raitobezarius ];

  };

  nodes.machine = { config, ... }: {

    virtualisation.memorySize = 2048;

    services.netbox = {

      enable = true;

      package = oldNetbox;

    networking.firewall.allowedTCPPorts = [ 80 ];

    specialisation.upgrade.configuration.services.netbox.package = lib.mkForce pkgs.netbox;

    specialisation.upgrade.configuration.services.netbox.package = lib.mkForce newNetbox;

  };

  testScript = { nodes, ... }:

        (lib.concatStringsSep ".")

      ];

      oldApiVersion = apiVersion oldNetbox.version;

      newApiVersion = apiVersion pkgs.netbox.version;

      newApiVersion = apiVersion newNetbox.version;

    in

    ''

      start_all()

  };

  nodes.machine = { config, ... }: {

    virtualisation.memorySize = 2048;

    services.netbox = {

      enable = true;

      package = netbox;