Commit e71e4cae authored by Winter M's avatar Winter M
Browse files

build-support/rust/build-rust-crate/configure-crate: fix using features that... 

build-support/rust/build-rust-crate/configure-crate: fix using features that aren't valid Bash variable names

`cxx` has feature names like `c++20` [0], which are valid Cargo feature
names, but not valid Bash variable names.

[0]: https://docs.rs/crate/cxx/latest/features



Co-authored-by: default avatardavidscherer <dscherer1@gmail.com>
parent 9f65d4e7

pkgs/build-support/rust/build-rust-crate/configure-crate.nix

+5 −6
Original line number Diff line number Diff line
@@ -49,7 +49,7 @@ let 
  completeDepsDir = lib.concatStringsSep " " completeDeps;

  completeBuildDepsDir = lib.concatStringsSep " " completeBuildDeps;

  envFeatures = lib.concatStringsSep " " (

    map (f: lib.replaceStrings [ "-" ] [ "_" ] (lib.toUpper f)) crateFeatures

    map (f: "CARGO_FEATURE_${lib.replaceStrings [ "-" ] [ "_" ] (lib.toUpper f)}=1") crateFeatures

  );

in

''
@@ -206,11 +206,10 @@ in 
     (

       # Features should be set as environment variable for build scripts:

       # https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts

       for feature in ${envFeatures}; do

         export CARGO_FEATURE_$feature=1

       done



       target/build/${crateName}/build_script_build | tee target/build/${crateName}.opt

       #

       # We use `env` instead of `export` because it's possible for a Cargo feature name to contain a character that Bash does

       # not support for variables.

       env ${envFeatures} target/build/${crateName}/build_script_build | tee target/build/${crateName}.opt

     )



     set +e

pkgs/build-support/rust/build-rust-crate/test/default.nix

+5 −0
Original line number Diff line number Diff line
@@ -477,6 +477,7 @@ rec { 
          crateName = "build-script-feature-env";

          features = [

            "some-feature"

            "some-c++17-thing"

            "crate/another_feature"

          ];

          src = symlinkJoin {
@@ -488,6 +489,8 @@ rec { 
                fn feature_not_visible() {

                  assert!(std::env::var("CARGO_FEATURE_SOME_FEATURE").is_err());

                  assert!(option_env!("CARGO_FEATURE_SOME_FEATURE").is_none());

                  assert!(std::env::var("CARGO_FEATURE_SOME_C++17_THING").is_err());

                  assert!(option_env!("CARGO_FEATURE_SOME_C++17_THING").is_none());

                  assert!(std::env::var("CARGO_FEATURE_ANOTHER_FEATURE").is_err());

                  assert!(option_env!("CARGO_FEATURE_ANOTHER_FEATURE").is_none());

                }
@@ -497,6 +500,8 @@ rec { 
                fn main() {

                  assert!(std::env::var("CARGO_FEATURE_SOME_FEATURE").is_ok());

                  assert!(option_env!("CARGO_FEATURE_SOME_FEATURE").is_none());

                  assert!(std::env::var("CARGO_FEATURE_SOME_C++17_THING").is_ok());

                  assert!(option_env!("CARGO_FEATURE_SOME_C++17_THING").is_none());

                  assert!(std::env::var("CARGO_FEATURE_ANOTHER_FEATURE").is_err());

                  assert!(option_env!("CARGO_FEATURE_ANOTHER_FEATURE").is_none());

                }