Unverified Commit e522ddbc authored by Emily's avatar Emily Committed by GitHub
Browse files

electron_32: fix log spam when building on aarch64-linux (#378988)

parents 7ff8f554 ce04dc5e

pkgs/development/tools/electron/common.nix

+14 −0
Original line number Diff line number Diff line
@@ -159,6 +159,20 @@ in 
    ''

    + base.postPatch;



  env =

    base.env

    // lib.optionalAttrs (lib.versionOlder info.version "33" && stdenv.hostPlatform.isAarch64) {

      # Hydra fails to build electron_32.aarch64-linux as of 2025-01-05 due to

      # clang spamming deprecation warnings mid-build, causing the build log to

      # grow beyond the limit of 64mb and then getting killed by Hydra. This

      # renders our clang both too old for the latest chromium without the use

      # of -Wno-unknown-warning-option and also too new for electron_32 (M128).

      # For some reason, this is exclusively happening on aarch64-linux. To

      # unbreak the build on h.n.o, we simply disable those warnings for now.

      # https://hydra.nixos.org/build/283952243

      NIX_CFLAGS_COMPILE = base.env.NIX_CFLAGS_COMPILE + " -Wno-deprecated";

    };



  preConfigure =

    ''

      (