Commit de5a39f5 authored by Silvan Mosberger's avatar Silvan Mosberger
Browse files

CONTRIBUTING.md: Move boot loader-specific sentence to pkgs/README.md 

This needs a rewrite at some point..
parent 2ce1e0b2

CONTRIBUTING.md

+0 −2
Original line number Diff line number Diff line
@@ -506,8 +506,6 @@ To get a sense for what changes are considered mass rebuilds, see [previously me 
## Commit conventions

[commit-conventions]: #commit-conventions



- When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra.



- Create a commit for each logical unit.



- Check for unnecessary whitespace with `git diff --check` before committing.

nixos/README.md

+2 −0
Original line number Diff line number Diff line
@@ -10,6 +10,8 @@ You can add new module to your NixOS configuration file (usually it’s `/etc/ni 


## Reviewing contributions



When changing the bootloader installation process, extra care must be taken. Grub installations cannot be rolled back, hence changes may break people’s installations forever. For any non-trivial change to the bootloader please file a PR asking for review, especially from \@edolstra.



### Module updates



Module updates are submissions changing modules in some ways. These often contains changes to the options or introduce new options.