Commit ddf8b5da authored by Silvan Mosberger's avatar Silvan Mosberger
Browse files

lib.teams: Add githubMaintainers field 

This is so you can figure out who to ask to get added to the team

Also avoid an unecessary `{ inherit lib; }` argument
parent 428bd8f1

lib/tests/teams.nix

+5 −1
Original line number Diff line number Diff line
@@ -24,13 +24,17 @@ let 
          default = false;

        };

        members = lib.mkOption {

          type = types.listOf (types.submodule (import ./maintainer-module.nix { inherit lib; }));

          type = types.listOf (types.submodule ./maintainer-module.nix);

          default = [ ];

        };

        github = lib.mkOption {

          type = types.str;

          default = "";

        };

        githubMaintainers = lib.mkOption {

          type = types.listOf (types.submodule ./maintainer-module.nix);

          default = [ ];

        };

      };

    };

maintainers/computed-team-list.nix

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ lib.mapAttrs ( 
      members =

        maintainerSetToList attrs.github githubTeam.maintainers

        ++ maintainerSetToList attrs.github githubTeam.members;

      githubMaintainers = maintainerSetToList attrs.github githubTeam.maintainers;

    }

  else

    attrs

maintainers/team-list.nix

+4 −0
Original line number Diff line number Diff line
@@ -18,6 +18,10 @@ 
      or larger ecosystems within nixpkgs.

  - `github` will ping the specified GitHub team and sync the `members`, `scope` and `shortName` fields from it



  If `github` is specified and you'd like to be added to the team, contact one of the `githubMaintainers` of the team:



      nix eval -f lib teams.someTeam.githubMaintainers --json | jq



  More fields may be added in the future.



  When editing this file: