Unverified Commit dcbff436 authored by Pavol Rusnak's avatar Pavol Rusnak Committed by GitHub
Browse files

python312Packages.*: torch.distributed is now enabled on darwin too (#395602)

parents 47ef6f56 1d2fe24f
Loading
Loading
Loading
Loading
+0 −12
Original line number Diff line number Diff line
@@ -105,18 +105,6 @@ buildPythonPackage rec {
    ++ lib.optionals (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64) [
      # OSError: LanceError(IO): Resources exhausted: Failed to allocate additional 1245184 bytes for ExternalSorter[0]...
      "test_merge_insert_large"
    ]
    ++ lib.optionals stdenv.hostPlatform.isDarwin [
      # AttributeError: module 'torch.distributed' has no attribute 'is_initialized'
      "test_blob_api"
      "test_convert_int_tensors"
      "test_filtered_sampling_odd_batch_size"
      "test_ground_truth"
      "test_index_cast_centroids"
      "test_index_with_no_centroid_movement"
      "test_iter_filter"
      "test_iter_over_dataset_fixed_shape_tensor"
      "test_iter_over_dataset_fixed_size_lists"
    ];

  meta = {
+0 −4
Original line number Diff line number Diff line
@@ -85,10 +85,6 @@ buildPythonPackage rec {
      "test_list_of_text"
      "test_untrained_indexer"
    ]
    ++ lib.optionals stdenv.hostPlatform.isDarwin [
      # AttributeError: module 'torch.distributed' has no attribute 'init_process_group'
      "test_single_proc"
    ]
    ++ lib.optionals cudaSupport [
      # crashes with SIGBART
      "test_accuracy_calculator_and_faiss_with_torch_and_numpy"
+9 −5
Original line number Diff line number Diff line
@@ -72,9 +72,13 @@ buildPythonPackage rec {
      # tries to import `transformers` and download HuggingFace data
      "skorch/tests/test_hf.py"
    ]
    ++ lib.optionals (stdenv.hostPlatform.system != "x86_64-linux") [
      # torch.distributed is disabled by default in darwin
      # aarch64-linux also failed these tests
    ++ lib.optionals
      (stdenv.hostPlatform.system != "x86_64-linux" && stdenv.hostPlatform.system != "aarch64-darwin")
      [
        # these tests fail when running in parallel for multiple platforms with:
        # "RuntimeError: The server socket has failed to listen on any local
        # network address because they use the same hardcoded port." For now,
        # running for one platform per OS to avoid spurious failures.
        "skorch/tests/test_history.py"
      ];