treewide: remove unreferenced patch files (#308127)

Shows build and link errors in configure for ease of debugging which

options require what.

diff --git a/scripts/checks.sh b/scripts/checks.sh

index 64cbbf3..fab4d9b 100644

--- a/scripts/checks.sh

+++ b/scripts/checks.sh

@@ -425,7 +425,7 @@ try_compile()

 		echo "$1" > $__src || exit 1

 		shift

 		__cmd="$CC -c $CFLAGS $@ $__src -o $__obj"

-		$CC -c $CFLAGS "$@" $__src -o $__obj 2>/dev/null

+		$CC -c $CFLAGS "$@" $__src -o $__obj

 		;;

 	cxx)

 		__src=`tmp_file prog.cc`

@@ -433,7 +433,7 @@ try_compile()

 		echo "$1" > $__src || exit 1

 		shift

 		__cmd="$CXX -c $CXXFLAGS $@ $__src -o $__obj"

-		$CXX -c $CXXFLAGS "$@" $__src -o $__obj 2>/dev/null

+		$CXX -c $CXXFLAGS "$@" $__src -o $__obj

 		;;

 	esac

 	return $?

@@ -451,7 +451,7 @@ try_compile_link()

 		echo "$1" > $__src || exit 1

 		shift

 		__cmd="$CC $__src -o $__exe $CFLAGS $LDFLAGS $@"

-		$CC $__src -o $__exe $CFLAGS $LDFLAGS "$@" 2>/dev/null

+		$CC $__src -o $__exe $CFLAGS $LDFLAGS "$@"

 		;;

 	cxx)

 		__src=`tmp_file prog.cc`

@@ -459,7 +459,7 @@ try_compile_link()

 		echo "$1" > $__src || exit 1

 		shift

 		__cmd="$CXX $__src -o $__exe $CXXFLAGS $CXXLDFLAGS $@"

-		$CXX $__src -o $__exe $CXXFLAGS $CXXLDFLAGS "$@" 2>/dev/null

+		$CXX $__src -o $__exe $CXXFLAGS $CXXLDFLAGS "$@"

 		;;

 	esac

 	return $?

diff --git a/src/sage/libs/linbox/conversion.pxd b/src/sage/libs/linbox/conversion.pxd

index 7794c9edc3..1753277b1f 100644

--- a/src/sage/libs/linbox/conversion.pxd

+++ b/src/sage/libs/linbox/conversion.pxd

@@ -177,9 +177,8 @@ cdef inline Vector_integer_dense new_sage_vector_integer_dense(P, DenseVector_in

     - v -- linbox vector

     """

     cdef Vector_integer_dense res = P()

-    cdef cppvector[Integer] * vec = &v.refRep()

     cdef size_t i

     for i in range(<size_t> res._degree):

-        mpz_set(res._entries[i], vec[0][i].get_mpz_const())

+        mpz_set(res._entries[i], v.getEntry(i).get_mpz_const())

     return res

diff --git a/src/sage/libs/linbox/linbox.pxd b/src/sage/libs/linbox/linbox.pxd

index 9112d151f8..dcc482960c 100644

--- a/src/sage/libs/linbox/linbox.pxd

+++ b/src/sage/libs/linbox/linbox.pxd

@@ -32,7 +32,7 @@ cdef extern from "linbox/matrix/dense-matrix.h":

         ctypedef Modular_double Field

         ctypedef double Element

         DenseMatrix_Modular_double(Field F, size_t m, size_t n)

-        DenseMatrix_Modular_double(Field F, Element*, size_t m, size_t n)

+        DenseMatrix_Modular_double(Field F, size_t m, size_t n, Element*)

         void setEntry(size_t i, size_t j, Element& a)

         Element &getEntry(size_t i, size_t j)

@@ -42,7 +42,7 @@ cdef extern from "linbox/matrix/dense-matrix.h":

         ctypedef Modular_float Field

         ctypedef float Element

         DenseMatrix_Modular_float(Field F, size_t m, size_t n)

-        DenseMatrix_Modular_float(Field F, Element*, size_t m, size_t n)

+        DenseMatrix_Modular_float(Field F, size_t m, size_t n, Element*)

         void setEntry(size_t i, size_t j, Element& a)

         Element &getEntry(size_t i, size_t j)

@@ -101,7 +101,6 @@ cdef extern from "linbox/vector/vector.h":

         DenseVector_integer (Field &F)

         DenseVector_integer (Field &F, long& m)

         DenseVector_integer (Field &F, cppvector[Integer]&)

-        cppvector[Element]& refRep()

         size_t size()

         void resize(size_t)

         void resize(size_t n, const Element&)

diff --git a/src/sage/matrix/matrix_modn_dense_template.pxi b/src/sage/matrix/matrix_modn_dense_template.pxi

index 010365d76f..3d60726ff9 100644

--- a/src/sage/matrix/matrix_modn_dense_template.pxi

+++ b/src/sage/matrix/matrix_modn_dense_template.pxi

@@ -219,7 +219,7 @@ cdef inline linbox_echelonize_efd(celement modulus, celement* entries, Py_ssize_

         return 0,[]

     cdef ModField *F = new ModField(<long>modulus)

-    cdef DenseMatrix *A = new DenseMatrix(F[0], <ModField.Element*>entries,<Py_ssize_t>nrows, <Py_ssize_t>ncols)

+    cdef DenseMatrix *A = new DenseMatrix(F[0], <Py_ssize_t>nrows, <Py_ssize_t>ncols, <ModField.Element*>entries)

     cdef Py_ssize_t r = reducedRowEchelonize(A[0])

     cdef Py_ssize_t i,j

     for i in range(nrows):

diff --unified --recursive a/src/gui/TopologyTools.cc b/src/gui/TopologyTools.cc

--- a/src/gui/TopologyTools.cc	2021-07-05 05:11:47.000000000 +0200

+++ b/src/gui/TopologyTools.cc	2022-12-07 22:35:20.444054124 +0100

@@ -3448,7 +3448,7 @@

 			std::find_if(

 					d_visible_boundary_section_seq.begin(),

 					d_visible_boundary_section_seq.end(),

-					boost::bind(&VisibleSection::d_section_info_index, _1) ==

+					boost::bind(&VisibleSection::d_section_info_index, boost::placeholders::_1) ==

 						boost::cref(section_index));

 	if (visible_section_iter == d_visible_boundary_section_seq.end())

@@ -3467,7 +3467,7 @@

 			std::find_if(

 					d_visible_interior_section_seq.begin(),

 					d_visible_interior_section_seq.end(),

-					boost::bind(&VisibleSection::d_section_info_index, _1) ==

+					boost::bind(&VisibleSection::d_section_info_index, boost::placeholders::_1) ==

 						boost::cref(section_index));

 	if (visible_section_iter == d_visible_interior_section_seq.end())

diff --unified --recursive a/src/presentation/ReconstructionGeometryRenderer.cc b/src/presentation/ReconstructionGeometryRenderer.cc

--- a/src/presentation/ReconstructionGeometryRenderer.cc	2021-07-05 05:11:50.000000000 +0200

+++ b/src/presentation/ReconstructionGeometryRenderer.cc	2022-12-07 22:36:11.117884262 +0100

@@ -274,7 +274,7 @@

 GPlatesPresentation::ReconstructionGeometryRenderer::RenderParamsPopulator::visit_reconstruct_visual_layer_params(

 		const ReconstructVisualLayerParams &params)

 {

-	d_render_params.show_vgp = boost::bind(&ReconstructVisualLayerParams::show_vgp, &params, _1, _2);

+	d_render_params.show_vgp = boost::bind(&ReconstructVisualLayerParams::show_vgp, &params, boost::placeholders::_1, boost::placeholders::_2);

 	d_render_params.vgp_draw_circular_error = params.get_vgp_draw_circular_error();

 	d_render_params.fill_polygons = params.get_fill_polygons();

 	d_render_params.fill_polylines = params.get_fill_polylines();

diff --unified --recursive a/src/presentation/VisualLayerRegistry.cc b/src/presentation/VisualLayerRegistry.cc

--- a/src/presentation/VisualLayerRegistry.cc	2021-07-05 05:11:50.000000000 +0200

+++ b/src/presentation/VisualLayerRegistry.cc	2022-12-07 22:38:12.950877614 +0100

@@ -448,7 +448,7 @@

 			&GPlatesQtWidgets::ReconstructScalarCoverageLayerOptionsWidget::create,

 			boost::bind(

 					&ReconstructScalarCoverageVisualLayerParams::create,

-					_1),

+					boost::placeholders::_1),

 			true);

 	registry.register_visual_layer_type(

@@ -498,7 +498,7 @@

 					// NOTE: We pass in ViewState and not the GlobeAndMapWidget, obtained from

 					// ViewportWindow, because ViewportWindow is not yet available (a reference to

 					// it not yet been initialised inside ViewState) so accessing it would crash...

-					_1, boost::ref(view_state)),

+					boost::placeholders::_1, boost::ref(view_state)),

 			true);

 	// DERIVED_DATA group.

@@ -549,7 +549,7 @@

 			&GPlatesQtWidgets::VelocityFieldCalculatorLayerOptionsWidget::create,

 			boost::bind(

 					&VelocityFieldCalculatorVisualLayerParams::create,

-					_1, boost::cref(view_state.get_rendered_geometry_parameters())),

+					boost::placeholders::_1, boost::cref(view_state.get_rendered_geometry_parameters())),

 			true);

 	using namespace  GPlatesUtils;

diff --unified --recursive a/src/qt-widgets/ViewportWindow.cc b/src/qt-widgets/ViewportWindow.cc

--- a/src/qt-widgets/ViewportWindow.cc	2021-08-05 05:44:01.000000000 +0200

+++ b/src/qt-widgets/ViewportWindow.cc	2022-12-07 22:39:20.487981302 +0100

@@ -326,7 +326,7 @@

 			*d_geometry_operation_state_ptr,

 			*d_modify_geometry_state,

 			*d_measure_distance_state_ptr,

-			boost::bind(&canvas_tool_status_message, boost::ref(*this), _1),

+			boost::bind(&canvas_tool_status_message, boost::ref(*this), boost::placeholders::_1),

 			get_view_state(),

 			*this);

diff --git a/source/thirdparty/breakpad/src/client/linux/handler/exception_handler.cc b/source/thirdparty/breakpad/src/client/linux/handler/exception_handler.cc

index ca353c4099..499be0a986 100644

--- a/source/thirdparty/breakpad/src/client/linux/handler/exception_handler.cc

+++ b/source/thirdparty/breakpad/src/client/linux/handler/exception_handler.cc

@@ -138,7 +138,7 @@ void InstallAlternateStackLocked() {

   // SIGSTKSZ may be too small to prevent the signal handlers from overrunning

   // the alternative stack. Ensure that the size of the alternative stack is

   // large enough.

-  static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);

+  const unsigned kSigStackSize = std::max<unsigned>(16384, SIGSTKSZ);

   // Only set an alternative stack if there isn't already one, or if the current

   // one is too small.