Unverified Commit d837bd0d authored by Weijia Wang's avatar Weijia Wang Committed by GitHub
Browse files

Merge pull request #232892 from nevivurn/feature/remove-wasm

{python3Packages.manticore,python3Packages.wasm}: remove 
parents 43d27d07 7c5d339b
Loading
Loading
Loading
Loading
+0 −136
Original line number Diff line number Diff line
{ lib
, buildPythonPackage
, capstone
, crytic-compile
, fetchFromGitHub
, intervaltree
, ply
, prettytable
, protobuf
, pyelftools
, pyevmasm
, pysha3
, pytestCheckHook
, pythonOlder
, pyyaml
, rlp
, stdenv
, unicorn
, wasm
, yices
, z3
}:

buildPythonPackage rec {
  pname = "manticore";
  version = "0.3.7";
  format = "setuptools";

  disabled = pythonOlder "3.7";

  src = fetchFromGitHub {
    owner = "trailofbits";
    repo = "manticore";
    rev = version;
    hash = "sha256-+17VBfAtkZZIi3SF5Num1Uqg3WjIpgbz3Jx65rD5zkM=";
  };

  propagatedBuildInputs = [
    crytic-compile
    intervaltree
    ply
    prettytable
    protobuf
    pyevmasm
    pysha3
    pyyaml
    rlp
    wasm
  ] ++ lib.optionals (stdenv.isLinux) [
    capstone
    pyelftools
    unicorn
  ];

  postPatch = ''
    # Python API is not used in the code, only z3 from PATH
    substituteInPlace setup.py \
      --replace "z3-solver" "" \
      --replace "crytic-compile==0.2.2" "crytic-compile>=0.2.2"
  '';

  nativeCheckInputs = [
    pytestCheckHook
  ];

  preCheck = ''
    export PATH=${yices}/bin:${z3}/bin:$PATH
  '';

  disabledTestPaths = [
    "tests/ethereum" # Enable when solc works again
    "tests/ethereum_bench"
  ] ++ lib.optionals (!stdenv.isLinux) [
    "tests/native"
    "tests/other/test_locking.py"
    "tests/other/test_state_introspection.py"
  ];

  disabledTests = [
    # Failing tests
    "test_chmod"
    "test_timeout"
    "test_wasm_main"
    # Slow tests
    "testmprotectFailSymbReading"
    "test_ConstraintsForking"
    "test_resume"
    "test_symbolic"
    "test_symbolic_syscall_arg"
    "test_state_merging"
    "test_decree"
    "test_register_comparison"
    "test_arguments_assertions_armv7"
    "test_integration_basic_stdout"
    "test_fclose_linux_amd64"
    "test_fileio_linux_amd64"
    "test_arguments_assertions_amd64"
    "test_ioctl_bogus"
    "test_ioctl_socket"
    "test_brk_regression"
    "test_basic_arm"
    "test_logger_verbosity"
    "test_profiling_data"
    "test_integration_basic_stdin"
    "test_getchar"
    "test_ccmp_reg"
    "test_ld1_mlt_structs"
    "test_ccmp_imm"
    "test_try_to_allocate_greater_than_last_space_memory_page_12"
    "test_not_enough_memory_page_12"
    "test_PCMPISTRI_30_symbolic"
    "test_ld1_mlt_structs"
    "test_time"
    "test_implicit_call"
    "test_trace"
    "test_plugin"
    # Tests are failing with latest unicorn
    "Aarch64UnicornInstructions"
    "test_integration_resume"
  ];

  pythonImportsCheck = [
    "manticore"
  ];

  meta = with lib; {
    # m.c.manticore:WARNING: Manticore is only supported on Linux. Proceed at your own risk!
    broken = (stdenv.isLinux && stdenv.isAarch64) || stdenv.isDarwin;
    description = "Symbolic execution tool for analysis of smart contracts and binaries";
    homepage = "https://github.com/trailofbits/manticore";
    changelog = "https://github.com/trailofbits/manticore/releases/tag/${version}";
    license = licenses.agpl3Only;
    platforms = platforms.unix;
    maintainers = with maintainers; [ arturcygan ];
  };
}
+0 −30
Original line number Diff line number Diff line
{ buildPythonPackage
, fetchPypi
, pythonAtLeast
, lib
}:

buildPythonPackage rec {
  pname = "wasm";
  version = "1.2";

  disabled = pythonAtLeast "3.10"; # project is abandoned, remove we whe move to py310/311

  src = fetchPypi {
    inherit pname version;
    sha256 = "179xcinfc35xgk0bf9y58kwxzymzk7c1p58w6khmqfiqvb91j3r8";
  };

  # there are no tests
  doCheck = false;

  pythonImportsCheck = [ "wasm" ];

  meta = with lib; {
    description = "WebAssembly decoder and disassembler";
    homepage = "https://github.com/athre0z/wasm";
    changelog = "https://github.com/athre0z/wasm/blob/master/CHANGELOG.md";
    license = licenses.mit;
    maintainers = with maintainers; [ arturcygan ];
  };
}
+2 −0
Original line number Diff line number Diff line
@@ -161,6 +161,7 @@ mapAliases ({
  mailman = throw "Please use pkgs.mailman"; # added 2022-04-29
  mailman-hyperkitty = throw "Please use pkgs.mailmanPackages.mailman-hyperkitty"; # added 2022-04-29
  mailman-web = throw "Please use pkgs.mailman-web"; # added 2022-04-29
  manticore = throw "manticore has been removed because its dependency wasm no longer builds and is unmaintained"; # added 2023-05-20
  mistune_0_8 = throw "mistune_0_8 was removed because it was outdated and insecure"; # added 2022-08-12
  mistune_2_0 = mistune; # added 2022-08-12
  mox = throw "mox was removed because it is unmaintained"; # added 2023-02-21
@@ -307,6 +308,7 @@ mapAliases ({
  uproot3-methods = throw "uproot3-methods has been removed"; # added 2022-12-13
  virtual-display = throw "virtual-display has been renamed to PyVirtualDisplay"; # added 2023-01-07
  Wand = wand; # added 2022-11-13
  wasm = throw "wasm has been removed because it no longer builds and is unmaintained"; # added 2023-05-20
  WazeRouteCalculator = wazeroutecalculator; # added 2021-09-29
  weakrefmethod = throw "weakrefmethod was removed since it's not needed in Python >= 3.4"; # added 2022-12-01
  webapp2 = throw "webapp2 is unmaintained since 2012"; # added 2022-05-29
+0 −6
Original line number Diff line number Diff line
@@ -5966,10 +5966,6 @@ self: super: with self; {

  manuel = callPackage ../development/python-modules/manuel { };

  manticore = callPackage ../development/python-modules/manticore {
    inherit (pkgs) z3;
  };

  mapbox = callPackage ../development/python-modules/mapbox { };

  mapbox-earcut = callPackage ../development/python-modules/mapbox-earcut { };
@@ -12794,8 +12790,6 @@ self: super: with self; {

  wasserstein = callPackage ../development/python-modules/wasserstein { };

  wasm = callPackage ../development/python-modules/wasm { };

  wasmerPackages = pkgs.recurseIntoAttrs (callPackage ../development/python-modules/wasmer { });
  inherit (self.wasmerPackages) wasmer wasmer-compiler-cranelift wasmer-compiler-llvm wasmer-compiler-singlepass;