Commit d52066e2 authored by Winter's avatar Winter
Browse files

ci/eval/compare: manage the "by: package-maintainer" label 

While OfBorg is still adding these, it takes a much longer time to do so
compared to the eval action. Since we're adding rebuild labels, I think
it'd be nice to just do it within the eval action.
parent f71ccdc1

.github/workflows/eval.yml

+5 −2
Original line number Diff line number Diff line
@@ -154,9 +154,12 @@ jobs: 
            --arg beforeResultDir ./targetResult \

            --arg afterResultDir "$(realpath prResult)" \

            --arg touchedFilesJson ./touched-files.json \

            --arg githubAuthorId "$AUTHOR_ID" \

            -o comparison



          cat comparison/step-summary.md >> "$GITHUB_STEP_SUMMARY"

        env:

          AUTHOR_ID: ${{ github.event.pull_request.user.id }}



      - name: Upload the combined results

        if: steps.targetRunId.outputs.targetRunId
@@ -211,10 +214,10 @@ jobs: 
      - name: Labelling pull request

        if: ${{ github.event_name == 'pull_request_target' && github.repository_owner == 'NixOS' }}

        run: |

          # Get all currently set rebuild labels

          # Get all currently set labels that we manage

          gh api \

            /repos/"$REPOSITORY"/issues/"$NUMBER"/labels \

            --jq '.[].name | select(startswith("10.rebuild"))' \

            --jq '.[].name | select(startswith("10.rebuild") or . == "11.by: package-maintainer")' \

            | sort > before



          # And the labels that should be there

ci/eval/compare/default.nix

+10 −1
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ 
  beforeResultDir,

  afterResultDir,

  touchedFilesJson,

  githubAuthorId,

  byName ? false,

}:

let
@@ -114,7 +115,15 @@ let 
          # Adds "10.rebuild-*-stdenv" label if the "stdenv" attribute was changed

          ++ lib.mapAttrsToList (kernel: _: "10.rebuild-${kernel}-stdenv") (

            lib.filterAttrs (_: kernelRebuilds: kernelRebuilds ? "stdenv") rebuildsByKernel

          );

          )

          # Adds the "11.by: package-maintainer" label if all of the packages directly

          # changed are maintained by the PR's author. (https://github.com/NixOS/ofborg/blob/df400f44502d4a4a80fa283d33f2e55a4e43ee90/ofborg/src/tagger.rs#L83-L88)

          ++ lib.optional (

            maintainers ? ${githubAuthorId}

            && lib.all (lib.flip lib.elem maintainers.${githubAuthorId}) (

              lib.flatten (lib.attrValues maintainers)

            )

          ) "11.by: package-maintainer";

      }

    );